Update to Kubernetes 1.16 #114
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Welcome @jbrette! |
Contributor
Author
|
/assign @mattfarina |
Contributor
Contributor
Member
Contributor
Author
|
@janetkuo Done xxx:~/go/src/sigs.k8s.io/application$ make deploy REGISTRY=keleustes
cd hack/tools; ./install_kustomize.sh
+ [[ -f bin/kustomize ]]
+ mkdir -p ./bin
+ curl -L https://github.com/kubernetes-sigs/kustomize/releases/download/v3.2.0/kustomize_3.2.0_linux_amd64 -o ./bin/kustomize
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 618 0 618 0 0 2032 0 --:--:-- --:--:-- --:--:-- 2032
100 25.3M 100 25.3M 0 0 3163k 0 0:00:08 0:00:08 --:--:-- 4207k
+ chmod +x ./bin/kustomize
hack/tools/bin/kustomize build config/default | kubectl apply -f -
namespace/application-system created
customresourcedefinition.apiextensions.k8s.io/applications.app.k8s.io created
clusterrole.rbac.authorization.k8s.io/application-manager-role created
clusterrolebinding.rbac.authorization.k8s.io/application-manager-rolebinding created
service/application-controller-manager-service created
statefulset.apps/application-controller-manager createdxxx:~/go/src/sigs.k8s.io/application$ kubectl get all
NAME TYPE CLUSTER-IP EXTERNAL-IP PORT(S) AGE
service/kubernetes ClusterIP 10.96.0.1 <none> 443/TCP 57mxxx:~/go/src/sigs.k8s.io/application$ kubectl get all --all-namespaces
NAMESPACE NAME READY STATUS RESTARTS AGE
application-system pod/application-controller-manager-0 1/1 Running 0 12s
argo pod/argo-ui-5bf4fb7cc-h9qfd 1/1 Running 0 56m
argo pod/argo-workflow-controller-dc4db947d-dxn4r 1/1 Running 0 56m
kube-system pod/calico-etcd-jvr2x 1/1 Running 0 56m
kube-system pod/calico-kube-controllers-6944fb5984-7gq77 1/1 Running 0 56m
kube-system pod/calico-node-9j4jc 1/1 Running 0 56m
kube-system pod/coredns-6955765f44-lbql7 1/1 Running 0 56m
kube-system pod/coredns-6955765f44-twwm6 1/1 Running 0 56m
kube-system pod/etcd-kubedgesdk 1/1 Running 0 57m
kube-system pod/kube-apiserver-kubedgesdk 1/1 Running 0 57m
kube-system pod/kube-controller-manager-kubedgesdk 1/1 Running 0 57m
kube-system pod/kube-proxy-bngzx 1/1 Running 0 56m
kube-system pod/kube-scheduler-kubedgesdk 1/1 Running 0 57m
kube-system pod/tiller-deploy-68cff9d9cb-kknfr 1/1 Running 0 56m
NAMESPACE NAME TYPE CLUSTER-IP EXTERNAL-IP PORT(S) AGE
application-system service/application-controller-manager-service ClusterIP 10.101.88.95 <none> 443/TCP 12s
argo service/argo-ui ClusterIP 10.110.5.212 <none> 80/TCP 56m
default service/kubernetes ClusterIP 10.96.0.1 <none> 443/TCP 57m
kube-system service/calico-etcd ClusterIP 10.96.232.136 <none> 6666/TCP 57m
kube-system service/kube-dns ClusterIP 10.96.0.10 <none> 53/UDP,53/TCP,9153/TCP 57m
kube-system service/tiller-deploy ClusterIP 10.100.115.208 <none> 44134/TCP 56m
NAMESPACE NAME DESIRED CURRENT READY UP-TO-DATE AVAILABLE NODE SELECTOR AGE
kube-system daemonset.apps/calico-etcd 1 1 1 1 1 node-role.kubernetes.io/master= 57m
kube-system daemonset.apps/calico-node 1 1 1 1 1 beta.kubernetes.io/os=linux 57m
kube-system daemonset.apps/kube-proxy 1 1 1 1 1 beta.kubernetes.io/os=linux 57m
NAMESPACE NAME READY UP-TO-DATE AVAILABLE AGE
argo deployment.apps/argo-ui 1/1 1 1 56m
argo deployment.apps/argo-workflow-controller 1/1 1 1 56m
kube-system deployment.apps/calico-kube-controllers 1/1 1 1 57m
kube-system deployment.apps/coredns 2/2 2 2 57m
kube-system deployment.apps/tiller-deploy 1/1 1 1 56m
NAMESPACE NAME DESIRED CURRENT READY AGE
argo replicaset.apps/argo-ui-5bf4fb7cc 1 1 1 56m
argo replicaset.apps/argo-workflow-controller-dc4db947d 1 1 1 56m
kube-system replicaset.apps/calico-kube-controllers-6944fb5984 1 1 1 56m
kube-system replicaset.apps/coredns-6955765f44 2 2 2 56m
kube-system replicaset.apps/tiller-deploy-68cff9d9cb 1 1 1 56m
NAMESPACE NAME READY AGE
application-system statefulset.apps/application-controller-manager 1/1 12sxxx:~/go/src/sigs.k8s.io/application$ make deploy-wordpress REGISTRY=keleustes
cd hack/tools; ./install_kustomize.sh
+ [[ -f bin/kustomize ]]
+ exit 0
mkdir -p /tmp/data1 /tmp/data2
hack/tools/bin/kustomize build examples/wordpress | kubectl apply -f -
secret/mysql-pass-82fh56g7gf created
service/wordpress-mysql-hsvc created
service/wordpress-webserver-hsvc created
service/wordpress-webserver-svc created
statefulset.apps/wordpress-mysql created
statefulset.apps/wordpress-webserver created
application.app.k8s.io/wordpress-01 created
persistentvolume/pv-volume-1 unchanged
persistentvolume/pv-volume-2 unchangedxxx:~/go/src/sigs.k8s.io/application$ kubectl get crds
NAME CREATED AT
applications.app.k8s.io 2020-02-01T20:57:30Zxxx:~/go/src/sigs.k8s.io/application$ kubectl get applications.app.k8s.io
NAME AGE
wordpress-01 24sxxx:~/go/src/sigs.k8s.io/application$ kubectl get applications.app.k8s.io wordpress-01 -o yamlapiVersion: app.k8s.io/v1beta1
kind: Application
metadata:
annotations:
kubectl.kubernetes.io/last-applied-configuration: |
{"apiVersion":"app.k8s.io/v1beta1","kind":"Application","metadata":{"annotations":{},"labels":{"app.kubernetes.io/name":"wordpress-01"},"name":"wordpress-01","namespace":"default"},"spec":{"componentKinds":[{"group":"core","kind":"Service"},{"group":"apps","kind":"StatefulSet"}],"description":"WordPress is open source software you can use to create a beautiful website, blog, or app.","icons":[{"size":"1000x1000","src":"https://s.w.org/style/images/about/WordPress-logotype-wmark.png","type":"image/png"},{"size":"2000x680","src":"https://s.w.org/style/images/about/WordPress-logotype-standard.png","type":"image/png"}],"keywords":["cms","blog","wordpress"],"links":[{"description":"About","url":"https://wordpress.org/"},{"description":"Web Server Dashboard","url":"https://metrics/internal/wordpress-01/web-app"},{"description":"Mysql Dashboard","url":"https://metrics/internal/wordpress-01/mysql"}],"maintainers":[{"email":"[email protected]","name":"Kenneth Owens"}],"owners":[{"email":"[email protected]","name":"Kenneth Owens"}],"selector":{"matchLabels":{"app.kubernetes.io/name":"wordpress-01"}},"type":"wordpress","version":"4.9.4"}}
creationTimestamp: "2020-02-01T20:58:05Z"
generation: 2
labels:
app.kubernetes.io/name: wordpress-01
name: wordpress-01
namespace: default
resourceVersion: "8367"
selfLink: /apis/app.k8s.io/v1beta1/namespaces/default/applications/wordpress-01
uid: 2b088029-4b1e-4b9b-8710-503a269f61b3
spec:
componentKinds:
- group: core
kind: Service
- group: apps
kind: StatefulSet
descriptor: {}
selector:
matchLabels:
app.kubernetes.io/name: wordpress-01
status:
components:
- group: apps/v1
kind: StatefulSet
link: /apis/apps/v1/namespaces/default/statefulsets/wordpress-mysql
name: wordpress-mysql
status: Ready
- group: apps/v1
kind: StatefulSet
link: /apis/apps/v1/namespaces/default/statefulsets/wordpress-webserver
name: wordpress-webserver
status: Ready
conditions:
- lastTransitionTime: "2020-02-01T20:58:07Z"
lastUpdateTime: "2020-02-01T20:58:07Z"
message: all components ready
reason: ComponentsReady
status: "True"
type: Ready
- lastTransitionTime: "2020-02-01T20:58:07Z"
lastUpdateTime: "2020-02-01T20:58:07Z"
message: No error seen
reason: NoError
status: "False"
type: Error |
barney-s
reviewed
Feb 2, 2020
Contributor
barney-s
left a comment
There was a problem hiding this comment.
Thanks for rebasing. Minor comments.
PTAL
|
|
||
| # Build | ||
| RUN CGO_ENABLED=0 GOOS=linux GOARCH=amd64 go build -a -o manager sigs.k8s.io/application/cmd/manager | ||
| ARG ARCH |
Contributor
There was a problem hiding this comment.
Would you make amd64 default ARCH ?
ARG ARCH=amd64
| RUN CGO_ENABLED=0 GOOS=linux GOARCH=amd64 go build -a -o manager sigs.k8s.io/application/cmd/manager | ||
| ARG ARCH | ||
| RUN CGO_ENABLED=0 GOOS=linux GOARCH=${ARCH} \ | ||
| go build -a -ldflags '-extldflags "-static"' \ |
Contributor
There was a problem hiding this comment.
May we know what prompted static linker flag ?
| $(KUSTOMIZE) build config/default | kubectl delete -f - | ||
|
|
||
| # Deploy wordpress | ||
| deploy-wordpress: $(KUSTOMIZE) |
Contributor
There was a problem hiding this comment.
This is a wonderful thing. Thanks. Do you think we could add this to e2e test ?
If not now may be later.
| clean: | ||
| go clean --cache | ||
| rm -f $(COVER_FILE) | ||
| rm -f $(TOOLS_BIN_DIR)/kustomize |
Contributor
There was a problem hiding this comment.
Does existing .gitignore ignore the TOOLS_BIN_DIR ?
| containers: | ||
| # Change the value of image field below to your controller image URL | ||
| - image: IMAGE_URL | ||
| - image: keleustes/application-controller-amd64:dev |
| matchLabels: | ||
| app.kubernetes.io/name: "wordpress-01" | ||
| componentKinds: | ||
| - group: core |
Contributor
There was a problem hiding this comment.
Would you try without core in this. Does it work ?
| type: "image/png" | ||
| size: "2000x680" | ||
| maintainers: | ||
| - name: Kenneth Owens |
Contributor
There was a problem hiding this comment.
please change this to a generic name ?
Contributor
|
/lgtm |
Contributor
|
@janetkuo Would you please approve this change. |
janetkuo
approved these changes
Feb 4, 2020
Member
|
/approve @jbrette thank you! |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: janetkuo, jbrette The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make deploy hack/tools/bin/kustomize build config/default | kubectl apply -f - namespace/application-system created customresourcedefinition.apiextensions.k8s.io/applications.app.k8s.io created clusterrole.rbac.authorization.k8s.io/application-manager-role created clusterrolebinding.rbac.authorization.k8s.io/application-manager-rolebinding created service/application-controller-manager-service created statefulset.apps/application-controller-manager createdmake deploy-wordpress mkdir -p /tmp/data1 /tmp/data2 hack/tools/bin/kustomize build examples/wordpress | kubectl apply -f - secret/mysql-pass-82fh56g7gf created service/wordpress-mysql-hsvc created service/wordpress-webserver-hsvc created service/wordpress-webserver-svc created statefulset.apps/wordpress-mysql created statefulset.apps/wordpress-webserver created application.app.k8s.io/wordpress-01 created persistentvolume/pv-volume-1 created persistentvolume/pv-volume-2 createdapiVersion: v1 items: - apiVersion: app.k8s.io/v1beta1 kind: Application metadata: annotations: kubectl.kubernetes.io/last-applied-configuration: | {"apiVersion":"app.k8s.io/v1beta1","kind":"Application","metadata":{"annotations":{},"labels":{"app.kubernetes.io/name":"wordpress-01"},"name":"wordpress-01","namespace":"default"},"spec":{"componentKinds":[{"group":"core","kind":"Service"},{"group":"apps","kind":"StatefulSet"}],"description":"WordPress is open source software you can use to create a beautiful website, blog, or app.","icons":[{"size":"1000x1000","src":"https://s.w.org/style/images/about/WordPress-logotype-wmark.png","type":"image/png"},{"size":"2000x680","src":"https://s.w.org/style/images/about/WordPress-logotype-standard.png","type":"image/png"}],"keywords":["cms","blog","wordpress"],"links":[{"description":"About","url":"https://wordpress.org/"},{"description":"Web Server Dashboard","url":"https://metrics/internal/wordpress-01/web-app"},{"description":"Mysql Dashboard","url":"https://metrics/internal/wordpress-01/mysql"}],"maintainers":[{"email":"[email protected]","name":"Kenneth Owens"}],"owners":[{"email":"[email protected]","name":"Kenneth Owens"}],"selector":{"matchLabels":{"app.kubernetes.io/name":"wordpress-01"}},"type":"wordpress","version":"4.9.4"}} creationTimestamp: "2019-10-10T04:43:00Z" generation: 8 labels: app.kubernetes.io/name: wordpress-01 name: wordpress-01 namespace: default resourceVersion: "1359" selfLink: /apis/app.k8s.io/v1beta1/namespaces/default/applications/wordpress-01 uid: 81a6555b-5590-4022-9c1d-bc93f4878321 spec: componentKinds: - group: core kind: Service - group: apps kind: StatefulSet descriptor: {} selector: matchLabels: app.kubernetes.io/name: wordpress-01 status: components: - group: apps/v1 kind: StatefulSet link: /apis/apps/v1/namespaces/default/statefulsets/wordpress-mysql name: wordpress-mysql status: Ready - group: apps/v1 kind: StatefulSet link: /apis/apps/v1/namespaces/default/statefulsets/wordpress-webserver name: wordpress-webserver status: Ready conditions: - lastTransitionTime: "2019-10-10T04:44:50Z" lastUpdateTime: "2019-10-10T04:44:50Z" message: all components ready reason: ComponentsReady status: "True" type: Ready - lastTransitionTime: "2019-10-10T04:43:00Z" lastUpdateTime: "2019-10-10T04:43:00Z" message: No error seen reason: NoError status: "False" type: Error kind: List metadata: resourceVersion: "" selfLink: ""