Skip to content

Stablize the E2E test #138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
k8s-ci-robot merged 3 commits into from
Jan 31, 2020
Merged

Stablize the E2E test #138

k8s-ci-robot merged 3 commits into from
Jan 31, 2020

Conversation

@nan-yu
Copy link
Contributor

@nan-yu nan-yu commented Jan 30, 2020

No description provided.

nan-yu added 3 commits January 30, 2020 11:51
@nan-yu
Only keep one node in the test cluster to avoid out-of-sync or delays
7010561
@nan-yu
Remove e2e-prow.sh
f75e811 
It is not being used currently. The script also includes some hard-coded
path which has been changed. Removing it to avoid extra unnecessary
maintenance.
@nan-yu
Check if CRD has Established == true condition
7a65edc
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 30, 2020
@nan-yu nan-yu requested review from barney-s and mortent and removed request for michelleN and pwittrock January 30, 2020 22:15
@nan-yu
Copy link
Contributor Author

nan-yu commented Jan 30, 2020

/assign @barney-s

@nan-yu
Copy link
Contributor Author

nan-yu commented Jan 30, 2020

Fixes: #137

@mortent
Copy link
Member

mortent commented Jan 30, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 30, 2020
@barney-s
Copy link
Contributor

barney-s commented Jan 31, 2020

Just to confirm we are removing prow since we dont want it for this repo. Just travis.

Why are you deleting the nodes as well from kind ?
We may need them once we extend e2e tests to include status tests.
May be have 1 node instead of 3.

@barney-s
Copy link
Contributor

barney-s commented Jan 31, 2020

/approve

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jan 31, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: barney-s, nan-yu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 31, 2020
@k8s-ci-robot k8s-ci-robot merged commit 5ab3652 into kubernetes-sigs:master Jan 31, 2020
@nan-yu nan-yu mentioned this pull request Feb 19, 2020
Closed
6 tasks
@spiffxp spiffxp mentioned this pull request Sep 29, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mortent mortent Awaiting requested review from mortent

@barney-s barney-s Awaiting requested review from barney-s

Assignees

@mortent mortent

@barney-s barney-s

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nan-yu @mortent @barney-s @k8s-ci-robot