Migrate application CRD to kubebuilder 2.0 #139
Conversation
|
/assign @barney-s |
|
@barney-s comments resolved. I did |
| return ctrl.Result{}, nil | ||
| } | ||
|
|
||
| newApplicationStatus.ObservedGeneration = app.Generation |
There was a problem hiding this comment.
Should we do this before we check whether there are any changes to the status and possibly return early? Seems like the application has been observed at the given version even if there are no changes to the status.
There was a problem hiding this comment.
If we move this before we check whether there are changes to the status, the observedGeneration field will keep increasing. I'll take a deep look into why it is happening. Before we figure it out, I suggest we keep it as is to make sure we get correct observedGeneration field.
barney-s
left a comment
There was a problem hiding this comment.
Thanks for rebasing. Minor comments.
Also would it be possible to add an e2e test that uses the docs example recently added.
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: barney-s, nan-yu The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
No description provided.