Skip to content

Conversation

@nan-yu
Copy link
Contributor

@nan-yu nan-yu commented Feb 7, 2020

No description provided.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 7, 2020
@nan-yu
Copy link
Contributor Author

nan-yu commented Feb 7, 2020

/assign @barney-s

```

## Installing the CRD
## Installing the CRD together with the controller
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just the controller.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It includes both the controller and the CRD.
$(TOOLBIN)/kustomize build config/default | kubectl apply -f - applied on config/default, which also includes the CRD. See: https://github.com/kubernetes-sigs/application/blob/master/config/default/kustomization.yaml#L21

Here is an example of the command output, which verified the CRD is created.

$ make deploy
cd config/manager && /usr/local/google/home/nanyu/go/src/sigs.k8s.io/application/hack/tools/bin/kustomize edit set image controller=gcr.io/nanyu-gke-dev/application-controller-amd64:dev
/usr/local/google/home/nanyu/go/src/sigs.k8s.io/application/hack/tools/bin/kustomize build config/default | kubectl apply -f -
namespace/application-system created
customresourcedefinition.apiextensions.k8s.io/applications.app.k8s.io created
role.rbac.authorization.k8s.io/application-leader-election-role created
clusterrole.rbac.authorization.k8s.io/application-manager-role created
clusterrole.rbac.authorization.k8s.io/application-proxy-role created
rolebinding.rbac.authorization.k8s.io/application-leader-election-rolebinding created
clusterrolebinding.rbac.authorization.k8s.io/application-manager-rolebinding created
clusterrolebinding.rbac.authorization.k8s.io/application-proxy-rolebinding created
service/application-controller-manager-metrics-service created
service/application-controller-manager-service created
deployment.apps/application-controller-manager created

@barney-s
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 10, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: barney-s, nan-yu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 10, 2020
@k8s-ci-robot k8s-ci-robot merged commit d8dce85 into kubernetes-sigs:master Feb 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants