Skip to content

Aggregate errors and set application condition to not-ready #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
k8s-ci-robot merged 1 commit into from
Feb 28, 2020
Merged

Aggregate errors and set application condition to not-ready #180

k8s-ci-robot merged 1 commit into from
Feb 28, 2020
+43 −38

Conversation

@nan-yu
Copy link
Contributor

@nan-yu nan-yu commented Feb 24, 2020

No description provided.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 24, 2020
@nan-yu
Copy link
Contributor Author

nan-yu commented Feb 24, 2020

This PR is based on #167 and needs rebase when #167 is merged.

@nan-yu nan-yu requested a review from barney-s February 24, 2020 23:52
@nan-yu
Copy link
Contributor Author

nan-yu commented Feb 24, 2020

/assign @barney-s

@k8s-ci-robot k8s-ci-robot requested review from ant31 and kow3ns February 24, 2020 23:53
barney-s
barney-s reviewed Feb 27, 2020
View reviewed changes
Copy link
Contributor

@barney-s barney-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please rebase and squash commits (the old commit was merged via #167 anyways)

@nan-yu
Mark application condition not ready when errors occur
15be037 
When errors occur in fetchComponentListResources, updateComponents,
we're unsure if all components are ready, and mostly likely, some components failed.
This commit mark the application condition to unready in this scenario.

Aggregate errors in application status's error condition
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 27, 2020
@barney-s
Copy link
Contributor

barney-s commented Feb 28, 2020

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 28, 2020
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Feb 28, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: barney-s, nan-yu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 28, 2020
@k8s-ci-robot k8s-ci-robot merged commit a3b16d8 into kubernetes-sigs:master Feb 28, 2020
@yuxiangqian yuxiangqian mentioned this pull request Mar 6, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@barney-s barney-s barney-s approved these changes

@ant31 ant31 Awaiting requested review from ant31

@kow3ns kow3ns Awaiting requested review from kow3ns

Assignees

@barney-s barney-s

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nan-yu @barney-s @k8s-ci-robot