Skip to content

liveness probe based on metrics - #2152

Merged
halamix2 merged 8 commits into
kyma-project:mainfrom
halamix2:probe-test
Dec 23, 2025
Merged

halamix2 merged 8 commits into
kyma-project:mainfrom
halamix2:probe-test

Conversation

@halamix2

@halamix2 halamix2 commented Dec 18, 2025 •

Copy link
Copy Markdown
Member

Description

Changes proposed in this pull request:

  • Check readiness based on metrics
    • if the reconciliation queue is empty then check liveness the old way, by issuing a request
    • if the queue is not empty check if the number of processed event is higher than in the previous liveness check

Related issue(s)

@hyperspace-pr-bot

Copy link
Copy Markdown
Contributor

Summary

The following content is AI-generated and provides a summary of the pull request:


Improve Health Check with Metrics Monitoring

New Features

✨ Enhanced the health checker to include metrics monitoring as a primary health indicator, with the existing event-based check serving as a fallback mechanism.

Changes

  • health.go:
    • Added metrics registry gathering to check controller activity
    • Implemented metric collection logging for debugging
    • Improved health check flow to prioritize metrics over event-based checks
    • Fixed typo in log message ("send" → "sent")
    • Reorganized imports for better code structure
    • Added clarifying comments about fallback behavior to prevent false negatives when event queue is full

GitHub Issues

  • #123: Fix orphan check
  • #33: Prepare customer-facing documentation for Serverless Manager
  • #43: Test the serverless module with the latest Kubernetes API supported by gardener

  • 🔄 Regenerate and Update Summary
  • ✏️ Insert as PR Description (deletes this comment)
  • 🗑️ Delete comment
PR Bot Information

Version: 1.16.33


💌 Have ideas or want to contribute? Create an issue and share your thoughts with us!
📑 Check out the documentation for more information.

Made with ❤️ by Hyperspace.

@halamix2
halamix2 force-pushed the probe-test branch 2 times, most recently from 99861ee to 3809073 Compare December 19, 2025 10:32
@halamix2 halamix2 changed the title probe test liveness probe based on metrics Dec 19, 2025
@halamix2
halamix2 force-pushed the probe-test branch 4 times, most recently from f84f439 to 022e363 Compare December 19, 2025 11:22
@halamix2
halamix2 marked this pull request as ready for review December 22, 2025 10:59
@halamix2
halamix2 requested a review from a team as a code owner December 22, 2025 10:59
@MichalKalke MichalKalke self-assigned this Dec 23, 2025
@halamix2
halamix2 merged commit f737ad6 into kyma-project:main Dec 23, 2025
72 of 73 checks passed
@halamix2
halamix2 deleted the probe-test branch December 23, 2025 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants