fix(user-controller): add AnnotationChangedPredicate for metadata Previously #6267
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lingdie
approved these changes
Dec 1, 2025
zijiren233
approved these changes
Dec 1, 2025
…nges Previously, the User controller only watched for GenerationChangedPredicate, which meant changes to metadata annotations (like owner transfers) would not trigger reconciliation. This caused namespace owner annotations to become out of sync when user ownership was transferred via OperationRequest. Adding AnnotationChangedPredicate ensures that any annotation changes on the User resource will trigger a reconcile, keeping namespace annotations in sync. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
95d5133 to
f8da7e1
Compare
Contributor
|
🤖 says: cherry pick action finished successfully 🎉! |
github-actions bot
pushed a commit
that referenced
this pull request
Dec 1, 2025
…viously (#6267) fix(user-controller): add AnnotationChangedPredicate for metadata changes Previously, the User controller only watched for GenerationChangedPredicate, which meant changes to metadata annotations (like owner transfers) would not trigger reconciliation. This caused namespace owner annotations to become out of sync when user ownership was transferred via OperationRequest. Adding AnnotationChangedPredicate ensures that any annotation changes on the User resource will trigger a reconcile, keeping namespace annotations in sync. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude <[email protected]>
cuisongliu
pushed a commit
that referenced
this pull request
Dec 1, 2025
…viously (#6270) fix(user-controller): add AnnotationChangedPredicate for metadata Previously (#6267) fix(user-controller): add AnnotationChangedPredicate for metadata changes Previously, the User controller only watched for GenerationChangedPredicate, which meant changes to metadata annotations (like owner transfers) would not trigger reconciliation. This caused namespace owner annotations to become out of sync when user ownership was transferred via OperationRequest. Adding AnnotationChangedPredicate ensures that any annotation changes on the User resource will trigger a reconcile, keeping namespace annotations in sync. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Jiahui <[email protected]> Co-authored-by: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…nges
Previously, the User controller only watched for GenerationChangedPredicate, which meant changes to metadata annotations (like owner transfers) would not trigger reconciliation. This caused namespace owner annotations to become out of sync when user ownership was transferred via OperationRequest.
Adding AnnotationChangedPredicate ensures that any annotation changes on the User resource will trigger a reconcile, keeping namespace annotations in sync.
🤖 Generated with Claude Code