fix(devbox): devbox no status fix #6461
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where devboxes could have an undefined status when devbox.status.phase doesn't match any key in the devboxStatusMap. The fix adds a fallback to devboxStatusMap.Error using the nullish coalescing operator.
Key changes:
- Added fallback status handling in
adaptDevboxListItemV2function - Added fallback status handling in
adaptDevboxDetailV2function
| template, | ||
| remark: devbox.metadata?.annotations?.[devboxRemarkKey] || '', | ||
| status: devboxStatusMap[devbox.status.phase], // use devbox.status.phase to get status | ||
| status: devboxStatusMap[devbox.status.phase] || devboxStatusMap.Error, // use devbox.status.phase to get status |
There was a problem hiding this comment.
Inconsistent fallback status handling: This code defaults to devboxStatusMap.Error when the phase is unknown, but in frontend/providers/devbox/app/api/v1/getDevboxDetail/route.ts (lines 55-57), a similar pattern defaults to devboxStatusMap.Pending. Since devboxStatusMap.Error is actually mapped to display as "Pending" in the UI (see constants/devbox.ts line 132), consider using devboxStatusMap.Pending directly for consistency across the codebase, or document why different fallbacks are needed in different contexts.
| status: devboxStatusMap[devbox.status.phase] || devboxStatusMap.Error, // use devbox.status.phase to get status | |
| status: devboxStatusMap[devbox.status.phase] || devboxStatusMap.Pending, // use devbox.status.phase to get status |
No description provided.