-
Notifications
You must be signed in to change notification settings - Fork 6
switch from brunch to webpack closes #13 #15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for the PR, @willfore! Can you put the Elixir version down to 1.6 to match i suspect that will fix the reason the build is failing Thanks again for making this change! |
|
No problem. All done! :) |
mix.exs
Outdated
| [ | ||
| app: :bootleg_phoenix, | ||
| version: @version, | ||
| elixir: "~> 1.7", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, please bump this down to 1.6 as well!
|
This new CI failure is due to more recent versions of |
|
@willfore I'm unable to push to your branch (this could be a config error on my side, i'm on a new laptop that i haven't fully set up yet), so could you just change line 86 of |
|
Sure thing, incoming. |
|
@willfore I've adjusted some package dependencies versions and adjusted some of the testing infrastructure to support this. Can you please add the necessary files to the fixture You can run the tests locally via |
…n. Tests passing locally.
|
I added all the needed files to match the changes. I did not update the README in regards to using with Phoenix < 1.4 as I wasn't sure about version numbers. Let me know if anything else needs to be done. |
|
This is great, thank you! I'll update the README today |
Updated package to use npm's webpack build function for building assets. Updated to the 0.7 version of Bootleg. Updated the readme to reflect the changes needed.