Skip to content

Conversation

@crazywoola
Copy link
Member

@crazywoola crazywoola commented May 15, 2025

Summary

commits

revert #19744
revert #19732
revert #18554

issues

close #19784
close #19782
close #19771
close #19768

PR

close #19765

cc @tinet-dongfb

It was a good feature, please consider adding some tests later. :) This pr causes several issues. Please take a look if you have some time.

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

@crazywoola crazywoola requested a review from laipz8200 May 15, 2025 14:20
@dosubot dosubot bot added the size:XL This PR changes 500-999 lines, ignoring generated files. label May 15, 2025
@crazywoola crazywoola requested a review from JzoNgKVO May 15, 2025 14:22
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label May 15, 2025
@crazywoola crazywoola merged commit 4dc06ee into main May 15, 2025
9 checks passed
@crazywoola crazywoola deleted the fix/check-var-rendering-errors branch May 15, 2025 14:39
@crazywoola
Copy link
Member Author

Please remove the current docker images and pull it again :(.

Scorpion1221 added a commit to yybht155/dify that referenced this pull request May 22, 2025
* commit '4dc06ee43fa2851ceeed5460463d8041f1bdc405': (152 commits)
  revert: langgenius#18554 (langgenius#19787)
  Fix TiDB vector configuration comment to correctly use 'tidb_vector' (langgenius#19767)
  Fix: style of dataset item in chatbot configure with theme dark (langgenius#19761)
  update readme (langgenius#19757)
  chore: upload describe image. (langgenius#19756)
  Fix: style of check list in dark mode (langgenius#19744)
  chore: Updates version numbers to 1.4.0 and related services (langgenius#19731)
  add: new brand image (langgenius#19676)
  fix: update background gradient and line positioning in Empty component (langgenius#19745)
  feat: update email templates (langgenius#19739)
  fix: broken behavior of rendering (langgenius#19732)
  chore: image allow "data:" in csp (langgenius#19728)
  fix: handle EndpointSetupFailedError in BasePluginClient (langgenius#19613)
  feat: update branding (langgenius#19719)
  Fix: Ensure unique index names for pgvector knowledge tables (langgenius#19672)
  fix: item data type wrong in iteration (langgenius#19709)
  Revert "Support for copying nodes between workflows (This feature is unrelated to remove functions. When using the copy function, the browser will permanently retain the last copied node)."" (langgenius#19708)
  fix: The init_azure_openai() method in the core/hosting_configuration.py file doesn't work (langgenius#19704) (langgenius#19705)
  feat(extension): support otel grpc exporter (langgenius#19686)
  Support for copying nodes between workflows (This feature is unrelated to remove functions. When using the copy function, the browser will permanently retain the last copied node)." (langgenius#19687)
  ...

# Conflicts:
#	api/core/helper/code_executor/python3/python3_transformer.py
#	api/core/tools/tool_file_manager.py
#	api/models/tools.py
#	api/uv.lock
jsincorporated pushed a commit to jsincorporated/asaAi that referenced this pull request Jul 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size:XL This PR changes 500-999 lines, ignoring generated files.

Projects

None yet

4 participants