Skip to content

feat(AlgebraicGeometry/IdealSheaf/IrreducibleComponent): subscheme structure on an irreducible component#35106

Open
tb65536 wants to merge 6 commits intoleanprover-community:masterfrom
tb65536:tb_irredscheme
Open

feat(AlgebraicGeometry/IdealSheaf/IrreducibleComponent): subscheme structure on an irreducible component#35106
tb65536 wants to merge 6 commits intoleanprover-community:masterfrom
tb65536:tb_irredscheme

Conversation

@tb65536
Copy link
Contributor

@tb65536 tb65536 commented Feb 11, 2026

This PR defines the subscheme structure on an irreducible component of a Noetherian scheme. See the module docstring for more details on this.


Open in Gitpod

@tb65536 tb65536 requested a review from erdOne February 11, 2026 00:32
@tb65536 tb65536 added awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. t-algebraic-geometry Algebraic geometry labels Feb 11, 2026
@github-actions
Copy link

github-actions bot commented Feb 11, 2026

PR summary 56d691c029

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference
Mathlib.AlgebraicGeometry.IdealSheaf.IrreducibleComponent (new file) 2286

Declarations diff

+ instance : IrreducibleSpace (X.irreducibleComponent Z hZ)
+ instance : IsClosedImmersion (X.irreducibleComponentι Z hZ)
+ instance [IrreducibleSpace X] : CategoryTheory.IsIso (X.irreducibleComponentι Z hZ) := by
+ irreducibleComponent
+ irreducibleComponentIdeal
+ irreducibleComponentι
+ irreducibleComponentι_apply

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot removed the awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. label Feb 11, 2026
Copy link
Member

@erdOne erdOne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is probably useful to have an IrreducibleSpace instance on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-algebraic-geometry Algebraic geometry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants