Skip to content

doc(CategoryTheory/Bicategory/Kan): clarify Kan adjunction docstrings#35146

Open
harahu wants to merge 3 commits intoleanprover-community:masterfrom
harahu:doc/typos-ct-bicategory-kan
Open

doc(CategoryTheory/Bicategory/Kan): clarify Kan adjunction docstrings#35146
harahu wants to merge 3 commits intoleanprover-community:masterfrom
harahu:doc/typos-ct-bicategory-kan

Conversation

@harahu
Copy link
Contributor

@harahu harahu commented Feb 11, 2026

  • The two IsAbsKan.adjunction docstrings in Kan/Adjunction were corrected to match the actual definitions: they now describe deriving adjunctions from absolute left Kan (co)universal data, not from an input adjunction.
  • Grammar and phrasing were cleaned up in the IsKan.adjunction docs (commutes with f/u).
  • In Kan/HasKan and Kan/IsKan, stale/non-API names were replaced by the current identifiers (lan, lanLift, HasLeftKanExtension) and Kan capitalization was normalized.

The issues were identified and fixed by Codex.

Open in Gitpod

@github-actions
Copy link

github-actions bot commented Feb 11, 2026

PR summary 60d0c4b32a

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for scripts/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot added the t-category-theory Category theory label Feb 11, 2026
@github-actions
Copy link

github-actions bot commented Feb 11, 2026

✅ PR Title Formatted Correctly

The title of this PR has been updated to match our commit style conventions.
Thank you!

@harahu harahu changed the title docs(CategoryTheory/Bicategory/Kan): clarify Kan adjunction docstrings doc(CategoryTheory/Bicategory/Kan): clarify Kan adjunction docstrings Feb 11, 2026
@dagurtomas dagurtomas added the awaiting-author A reviewer has asked the author a question or requested changes. label Feb 13, 2026
This patch is documentation-only in Kan/Adjunction, Kan/HasKan, and Kan/IsKan.

Reviewer guidance:
* The two IsAbsKan.adjunction docstrings in Kan/Adjunction were corrected to match the actual definitions: they now describe deriving adjunctions from absolute left Kan (co)universal data, not from an input adjunction.
* Grammar and phrasing were cleaned up in the IsKan.adjunction docs (commutes with f/u).
* In Kan/HasKan and Kan/IsKan, stale/non-API names were replaced by the current identifiers (lan, lanLift, HasLeftKanExtension) and Kan capitalization was normalized.

No definitions, theorems, or proofs were changed.
@harahu harahu force-pushed the doc/typos-ct-bicategory-kan branch from dcf4b20 to 4293166 Compare February 13, 2026 16:12
@harahu
Copy link
Contributor Author

harahu commented Feb 13, 2026

-awaiting-author

@github-actions github-actions bot removed the awaiting-author A reviewer has asked the author a question or requested changes. label Feb 13, 2026
@joelriou joelriou added the awaiting-author A reviewer has asked the author a question or requested changes. label Feb 17, 2026
harahu and others added 2 commits February 17, 2026 11:09
Co-authored-by: Joël Riou <37772949+joelriou@users.noreply.github.com>
@harahu
Copy link
Contributor Author

harahu commented Feb 17, 2026

-awaiting-author

@github-actions github-actions bot removed the awaiting-author A reviewer has asked the author a question or requested changes. label Feb 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-category-theory Category theory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants