Skip to content

refactor(Algebra/*): generalize of_ringEquiv lemmas#35351

Open
urkud wants to merge 1 commit intoleanprover-community:masterfrom
urkud:ringhominv
Open

refactor(Algebra/*): generalize of_ringEquiv lemmas#35351
urkud wants to merge 1 commit intoleanprover-community:masterfrom
urkud:ringhominv

Conversation

@urkud
Copy link
Member

@urkud urkud commented Feb 15, 2026

Some lemmas assumed that two modules over different rings
admit a semilinear equivalence with respect to a RingEquiv.
While this is mathematically equivalent
to the definition we use everywhere else
(a pair of RingHoms with RingHomInvPair assumptions),
it does not directly apply neither to the linear case,
nor to the starRingEnd case.

This PR drops of_ringEquiv theorems
and generalizes of_equiv theorems
to semilinear equivalences instead.


Open in Gitpod

Some lemmas assumed that two modules over different rings
admit a semilinear equivalence with respect to a `RingEquiv`.
While this is mathematically equivalent
to the definition we use everywhere else
(a pair of `RingHom`s with `RingHomInvPair` assumptions),
it does not directly apply neither to the linear case,
nor to the `starRingEnd` case.

This PR drops `of_ringEquiv` theorems
and generalizes `of_equiv` theorems
to semilinear equivalences instead.
@github-actions
Copy link

PR summary 99884c2730

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ Projective.of_equiv'
+ iff_of_equiv
+ of_ringEquiv_symm
+ toRingEquiv

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for scripts/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@urkud urkud requested a review from sgouezel February 15, 2026 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant