refactor(Algebra/*): generalize of_ringEquiv lemmas#35351
Open
urkud wants to merge 1 commit intoleanprover-community:masterfrom
Open
refactor(Algebra/*): generalize of_ringEquiv lemmas#35351urkud wants to merge 1 commit intoleanprover-community:masterfrom
of_ringEquiv lemmas#35351urkud wants to merge 1 commit intoleanprover-community:masterfrom
Conversation
Some lemmas assumed that two modules over different rings admit a semilinear equivalence with respect to a `RingEquiv`. While this is mathematically equivalent to the definition we use everywhere else (a pair of `RingHom`s with `RingHomInvPair` assumptions), it does not directly apply neither to the linear case, nor to the `starRingEnd` case. This PR drops `of_ringEquiv` theorems and generalizes `of_equiv` theorems to semilinear equivalences instead.
PR summary 99884c2730Import changes for modified filesNo significant changes to the import graph Import changes for all files
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some lemmas assumed that two modules over different rings
admit a semilinear equivalence with respect to a
RingEquiv.While this is mathematically equivalent
to the definition we use everywhere else
(a pair of
RingHoms withRingHomInvPairassumptions),it does not directly apply neither to the linear case,
nor to the
starRingEndcase.This PR drops
of_ringEquivtheoremsand generalizes
of_equivtheoremsto semilinear equivalences instead.