Skip to content

chore(Translate): use Term.applyAttributes#35409

Open
JovanGerb wants to merge 1 commit intoleanprover-community:masterfrom
JovanGerb:Jovan-translate-applyAttributes
Open

chore(Translate): use Term.applyAttributes#35409
JovanGerb wants to merge 1 commit intoleanprover-community:masterfrom
JovanGerb:Jovan-translate-applyAttributes

Conversation

@JovanGerb
Copy link
Contributor

@JovanGerb JovanGerb commented Feb 16, 2026

This PR uses the function Term.applyAttributes in to_additive/to_dual for applying attributes. Previously, the code that was there was a copy-paste of Term.applyAttributes (and this was outdated due to changes from the module system).

One advantage of the original implementation was the fact that it only calls pushInfoLeaf once, and in the new implementation this will typically be done twice for the same syntax. However, I think that this is not a good enough reason for duplicating so much code.


Open in Gitpod

@github-actions
Copy link

PR summary c1475f9635

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for scripts/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot added the t-meta Tactics, attributes or user commands label Feb 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-meta Tactics, attributes or user commands

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant