fix(docs): update brand logo statement link in github action #3630
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
jguddas
approved these changes
Oct 16, 2025
ericfennis
approved these changes
Oct 16, 2025
87kangsw
pushed a commit
to 87kangsw/lucide
that referenced
this pull request
Oct 24, 2025
ch4og
pushed a commit
to csmplay/mapban
that referenced
this pull request
Nov 18, 2025
This PR contains the following updates: | Package | Change | Age | Confidence | |---|---|---|---| | [lucide-react](https://lucide.dev) ([source](https://github.com/lucide-icons/lucide/tree/HEAD/packages/lucide-react)) | [`^0.539.0` -> `^0.554.0`](https://renovatebot.com/diffs/npm/lucide-react/0.539.0/0.554.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>lucide-icons/lucide (lucide-react)</summary> ### [`v0.554.0`](https://github.com/lucide-icons/lucide/releases/tag/0.554.0): Version 0.554.0 [Compare Source](lucide-icons/lucide@0.553.0...0.554.0) #### What's Changed - fix(icons): Rename fingerprint icon to fingerprint-pattern by [@​ericfennis](https://github.com/ericfennis) in [#​3767](lucide-icons/lucide#3767) - feat(docs): added lucide-rails third-party package by [@​theiereman](https://github.com/theiereman) in [#​3769](lucide-icons/lucide#3769) - fix(icons): changed `ampersand` icon by [@​jguddas](https://github.com/jguddas) in [#​3771](lucide-icons/lucide#3771) - fix(icons): changed `folder-git-2` icon by [@​jguddas](https://github.com/jguddas) in [#​3790](lucide-icons/lucide#3790) - fix(icons): update `anchor` icon by [@​jamiemlaw](https://github.com/jamiemlaw) in [#​2523](lucide-icons/lucide#2523) - feat(icons): added `calendars` icon by [@​jguddas](https://github.com/jguddas) in [#​3788](lucide-icons/lucide#3788) #### Breaking change For `lucide-react` and `lucide-solid`, imports for `Fingerprint` icon are changed to `FingerprintPattern`. ##### Lucide React ```diff - import { Fingerprint } from "lucide-react"; + import { FingerprintPattern } from "lucide-react"; ``` ##### Lucide Solid ```diff - import { Fingerprint } from "lucide/solid"; + import { FingerprintPattern } from "lucide/solid"; // Or - import Fingerprint from "lucide/solid/icons/fingerprint"; + import FingerprintPattern from "lucide/solid/icons/fingerprint-pattern"; ``` #### New Contributors - [@​theiereman](https://github.com/theiereman) made their first contribution in [#​3769](lucide-icons/lucide#3769) **Full Changelog**: <lucide-icons/lucide@0.553.0...0.554.0> ### [`v0.553.0`](https://github.com/lucide-icons/lucide/releases/tag/0.553.0): Version 0.553.0 [Compare Source](lucide-icons/lucide@0.552.0...0.553.0) #### What's Changed - feat(icons): added `mouse-pointer-2-off` icon by [@​domingasp](https://github.com/domingasp) in [#​3570](lucide-icons/lucide#3570) - fix(icons): changed `ruler-dimension-line` icon by [@​karsa-mistmere](https://github.com/karsa-mistmere) in [#​3433](lucide-icons/lucide#3433) - feat(docs): add keyboard shortcut for search by [@​dzonatan](https://github.com/dzonatan) in [#​3718](lucide-icons/lucide#3718) - fix(lucide-preact): handle `className` prop by [@​ocavue](https://github.com/ocavue) in [#​3751](lucide-icons/lucide#3751) - feat(icons): added chess pieces by [@​karsa-mistmere](https://github.com/karsa-mistmere) in [#​1945](lucide-icons/lucide#1945) #### New Contributors - [@​domingasp](https://github.com/domingasp) made their first contribution in [#​3570](lucide-icons/lucide#3570) **Full Changelog**: <lucide-icons/lucide@0.552.0...0.553.0> ### [`v0.552.0`](https://github.com/lucide-icons/lucide/releases/tag/0.552.0): Version 0.552.0 [Compare Source](lucide-icons/lucide@0.551.0...0.552.0) #### What's Changed - fix(icons/file): arcified folds by [@​karsa-mistmere](https://github.com/karsa-mistmere) in [#​3587](lucide-icons/lucide#3587) - feat(icons): added `solar-panel` icon by [@​UsamaKhan](https://github.com/UsamaKhan) in [#​2780](lucide-icons/lucide#2780) **Full Changelog**: <lucide-icons/lucide@0.551.0...0.552.0> ### [`v0.551.0`](https://github.com/lucide-icons/lucide/releases/tag/0.551.0): Version 0.551.0 [Compare Source](lucide-icons/lucide@0.550.0...0.551.0) #### What's Changed - feat(icons): added `clock-check` icon by [@​jguddas](https://github.com/jguddas) in [#​2402](lucide-icons/lucide#2402) **Full Changelog**: <lucide-icons/lucide@0.550.0...0.551.0> ### [`v0.550.0`](https://github.com/lucide-icons/lucide/releases/tag/0.550.0): Version 0.550.0 [Compare Source](lucide-icons/lucide@0.549.0...0.550.0) #### What's Changed - feat(icons): added `helicopter` icon by [@​liloudreams](https://github.com/liloudreams) in [#​2760](lucide-icons/lucide#2760) #### New Contributors - [@​liloudreams](https://github.com/liloudreams) made their first contribution in [#​2760](lucide-icons/lucide#2760) **Full Changelog**: <lucide-icons/lucide@0.549.0...0.550.0> ### [`v0.549.0`](https://github.com/lucide-icons/lucide/releases/tag/0.549.0): Version 0.549.0 [Compare Source](lucide-icons/lucide@0.548.0...0.549.0) #### What's Changed - fix(docs): Replace `pnpm install` with `pnpm add` across documentation. by [@​josch87](https://github.com/josch87) in [#​3735](lucide-icons/lucide#3735) - feat(docs): add new package for Go by [@​kaugesaar](https://github.com/kaugesaar) in [#​3736](lucide-icons/lucide#3736) - feat(icons): added `git-branch-minus` icon by [@​joris-gallot](https://github.com/joris-gallot) in [#​3586](lucide-icons/lucide#3586) #### New Contributors - [@​josch87](https://github.com/josch87) made their first contribution in [#​3735](lucide-icons/lucide#3735) - [@​kaugesaar](https://github.com/kaugesaar) made their first contribution in [#​3736](lucide-icons/lucide#3736) - [@​joris-gallot](https://github.com/joris-gallot) made their first contribution in [#​3586](lucide-icons/lucide#3586) **Full Changelog**: <lucide-icons/lucide@0.548.0...0.549.0> ### [`v0.548.0`](https://github.com/lucide-icons/lucide/releases/tag/0.548.0): Version 0.548.0 [Compare Source](lucide-icons/lucide@0.547.0...0.548.0) #### What's Changed - feat(docs): add new package for Slint by [@​cnlancehu](https://github.com/cnlancehu) in [#​3698](lucide-icons/lucide#3698) - docs(site): add introductions for packages in documentation by [@​mattheskaiser](https://github.com/mattheskaiser) in [#​3643](lucide-icons/lucide#3643) - Fix default prop by [@​ericfennis](https://github.com/ericfennis) in [#​3730](lucide-icons/lucide#3730) - feat(icons): added `gamepad-directional` icon by [@​felipeajzanetti](https://github.com/felipeajzanetti) in [#​3693](lucide-icons/lucide#3693) #### New Contributors - [@​cnlancehu](https://github.com/cnlancehu) made their first contribution in [#​3698](lucide-icons/lucide#3698) - [@​mattheskaiser](https://github.com/mattheskaiser) made their first contribution in [#​3643](lucide-icons/lucide#3643) - [@​felipeajzanetti](https://github.com/felipeajzanetti) made their first contribution in [#​3693](lucide-icons/lucide#3693) **Full Changelog**: <lucide-icons/lucide@0.547.0...0.548.0> ### [`v0.547.0`](https://github.com/lucide-icons/lucide/releases/tag/0.547.0): Version 0.547.0 [Compare Source](lucide-icons/lucide@0.546.0...0.547.0) #### What's Changed - fix(docs): update brand logo statement link in github action by [@​karsa-mistmere](https://github.com/karsa-mistmere) in [#​3630](lucide-icons/lucide#3630) - chore(deps): bump astro from 5.5.2 to 5.14.4 by [@​dependabot](https://github.com/dependabot)\[bot] in [#​3683](lucide-icons/lucide#3683) - fix(packages/lucide): replace elements inside `<template>` ([#​2635](lucide-icons/lucide#2635)) by [@​KhalidAlansary](https://github.com/KhalidAlansary) in [#​3576](lucide-icons/lucide#3576) - feat(icons): added `birdhouse` icon by [@​hieu-onefold](https://github.com/hieu-onefold) in [#​3378](lucide-icons/lucide#3378) #### New Contributors - [@​KhalidAlansary](https://github.com/KhalidAlansary) made their first contribution in [#​3576](lucide-icons/lucide#3576) - [@​hieu-onefold](https://github.com/hieu-onefold) made their first contribution in [#​3378](lucide-icons/lucide#3378) **Full Changelog**: <lucide-icons/lucide@0.546.0...0.547.0> ### [`v0.546.0`](https://github.com/lucide-icons/lucide/releases/tag/0.546.0): Version 0.546.0 [Compare Source](lucide-icons/lucide@0.545.0...0.546.0) #### What's Changed - fix(icons): changed `receipt-text` icon by [@​jguddas](https://github.com/jguddas) in [#​3553](lucide-icons/lucide#3553) - fix(docs): removed duplicate text in intro text by [@​nielsswinkels](https://github.com/nielsswinkels) in [#​3673](lucide-icons/lucide#3673) - feat(icons): add VS Code `squircle` base shape snippet by [@​danielbayley](https://github.com/danielbayley) in [#​3674](lucide-icons/lucide#3674) - fix(icons): changed `sword` icon by [@​jguddas](https://github.com/jguddas) in [#​3421](lucide-icons/lucide#3421) - feat(icons): added `monitor-cloud` icon by [@​karsa-mistmere](https://github.com/karsa-mistmere) in [#​3037](lucide-icons/lucide#3037) #### New Contributors - [@​nielsswinkels](https://github.com/nielsswinkels) made their first contribution in [#​3673](lucide-icons/lucide#3673) **Full Changelog**: <lucide-icons/lucide@0.545.0...0.546.0> ### [`v0.545.0`](https://github.com/lucide-icons/lucide/releases/tag/0.545.0): Version 0.545.0 [Compare Source](lucide-icons/lucide@0.544.0...0.545.0) #### What's Changed - fix(icons): changed `flame` icon by [@​jamiemlaw](https://github.com/jamiemlaw) in [#​3600](lucide-icons/lucide#3600) - fix(icons): arcified `square-m` icon by [@​jguddas](https://github.com/jguddas) in [#​3549](lucide-icons/lucide#3549) - chore(deps-dev): bump vite from 6.3.5 to 6.3.6 by [@​dependabot](https://github.com/dependabot)\[bot] in [#​3611](lucide-icons/lucide#3611) - fix(icons): changed `combine` icon by [@​jguddas](https://github.com/jguddas) in [#​3200](lucide-icons/lucide#3200) - fix(icons): changed `building-2` icon by [@​karsa-mistmere](https://github.com/karsa-mistmere) in [#​3509](lucide-icons/lucide#3509) - chore(deps): bump devalue from 5.1.1 to 5.3.2 by [@​dependabot](https://github.com/dependabot)\[bot] in [#​3638](lucide-icons/lucide#3638) - feat(icons): Add `motorbike` icon by [@​jamiemlaw](https://github.com/jamiemlaw) in [#​3371](lucide-icons/lucide#3371) **Full Changelog**: <lucide-icons/lucide@0.544.0...0.545.0> ### [`v0.544.0`](https://github.com/lucide-icons/lucide/releases/tag/0.544.0): Version 0.544.0 [Compare Source](lucide-icons/lucide@0.543.0...0.544.0) #### What's Changed - docs: update lucide-static documentation about raw string imports by [@​pascalduez](https://github.com/pascalduez) in [#​3524](lucide-icons/lucide#3524) - feat(icons): added `ev-charger` icon by [@​UsamaKhan](https://github.com/UsamaKhan) in [#​2781](lucide-icons/lucide#2781) #### New Contributors - [@​pascalduez](https://github.com/pascalduez) made their first contribution in [#​3524](lucide-icons/lucide#3524) **Full Changelog**: <lucide-icons/lucide@0.543.0...0.544.0> ### [`v0.543.0`](https://github.com/lucide-icons/lucide/releases/tag/0.543.0): Version 0.543.0 [Compare Source](lucide-icons/lucide@0.542.0...0.543.0) #### What's Changed - feat(preview-comment): put x-ray at top if there are more than 7 changed icons to prevent them from being cut of by [@​jguddas](https://github.com/jguddas) in [#​3589](lucide-icons/lucide#3589) - fix(icons): changed `church` icon by [@​karsa-mistmere](https://github.com/karsa-mistmere) in [#​2971](lucide-icons/lucide#2971) - chore(metadata): Added tags to `messages-square` by [@​jamiemlaw](https://github.com/jamiemlaw) in [#​3529](lucide-icons/lucide#3529) - fix(icons): Optimise `bug` icons by [@​jamiemlaw](https://github.com/jamiemlaw) in [#​3574](lucide-icons/lucide#3574) - fix(icons): changed list/text & derived icons by [@​karsa-mistmere](https://github.com/karsa-mistmere) in [#​3568](lucide-icons/lucide#3568) - fix(icons): changed `panel-top-bottom-dashed` icon by [@​jguddas](https://github.com/jguddas) in [#​3584](lucide-icons/lucide#3584) - fix(icons): changed `message-square-quote` icon by [@​jguddas](https://github.com/jguddas) in [#​3550](lucide-icons/lucide#3550) - fix(meta): added tag to `ship` metadata by [@​jguddas](https://github.com/jguddas) in [#​3559](lucide-icons/lucide#3559) - fix(meta): add tags to `id-card-lanyard` metadata by [@​jguddas](https://github.com/jguddas) in [#​3534](lucide-icons/lucide#3534) - fix(icons): changed `calendar-cog` icon by [@​jguddas](https://github.com/jguddas) in [#​3583](lucide-icons/lucide#3583) - chore(deps): bump astro from 5.5.2 to 5.13.2 by [@​dependabot](https://github.com/dependabot)\[bot] in [#​3564](lucide-icons/lucide#3564) - feat(packages): add new package for flutter by [@​vqh2602](https://github.com/vqh2602) in [#​3536](lucide-icons/lucide#3536) - feat(icons): added `house-heart` icon by [@​danielbayley](https://github.com/danielbayley) in [#​3239](lucide-icons/lucide#3239) **Full Changelog**: <lucide-icons/lucide@0.542.0...0.543.0> ### [`v0.542.0`](https://github.com/lucide-icons/lucide/releases/tag/0.542.0): Version 0.542.0 [Compare Source](lucide-icons/lucide@0.541.0...0.542.0) #### What's Changed - feat(docs): add MDN Web Docs & Nuxt to showcase by [@​karsa-mistmere](https://github.com/karsa-mistmere) in [#​3590](lucide-icons/lucide#3590) - feat(icons): added `list-chevrons-down-up` icon by [@​juliankellydesign](https://github.com/juliankellydesign) in [#​3492](lucide-icons/lucide#3492) #### New Contributors - [@​juliankellydesign](https://github.com/juliankellydesign) made their first contribution in [#​3492](lucide-icons/lucide#3492) **Full Changelog**: <lucide-icons/lucide@0.541.0...0.542.0> ### [`v0.541.0`](https://github.com/lucide-icons/lucide/releases/tag/0.541.0): Version 0.541.0 [Compare Source](lucide-icons/lucide@0.540.0...0.541.0) #### What's Changed - feat(packages/lucide): added support for providing a custom root element by [@​karsa-mistmere](https://github.com/karsa-mistmere) in [#​3543](lucide-icons/lucide#3543) - fix(icons): optimized `chrome` icon & renamed to `chromium` by [@​jguddas](https://github.com/jguddas) in [#​3572](lucide-icons/lucide#3572) - fix(icons): changed `wallpaper` icon by [@​jguddas](https://github.com/jguddas) in [#​3566](lucide-icons/lucide#3566) - fix(icons): optimized `cog` icon by [@​jguddas](https://github.com/jguddas) in [#​3548](lucide-icons/lucide#3548) - fix(icons): changed `building` icon by [@​karsa-mistmere](https://github.com/karsa-mistmere) in [#​3510](lucide-icons/lucide#3510) - feat(dpi-preview): add previous version for easier comparison by [@​jguddas](https://github.com/jguddas) in [#​3532](lucide-icons/lucide#3532) - feat(icons): added 'panel-dashed' variants + update tags on existing icons by [@​irvineacosta](https://github.com/irvineacosta) in [#​3500](lucide-icons/lucide#3500) **Full Changelog**: <lucide-icons/lucide@0.540.0...0.541.0> ### [`v0.540.0`](https://github.com/lucide-icons/lucide/releases/tag/0.540.0): Version 0.540.0 [Compare Source](lucide-icons/lucide@0.539.0...0.540.0) #### What's Changed - fix(license): add full text of Feather license by [@​jguddas](https://github.com/jguddas) in [#​3530](lucide-icons/lucide#3530) - fix(icons): changed `umbrella` icon by [@​karsa-mistmere](https://github.com/karsa-mistmere) in [#​3490](lucide-icons/lucide#3490) - docs(site): added official statement on brand logos in Lucide by [@​karsa-mistmere](https://github.com/karsa-mistmere) in [#​3541](lucide-icons/lucide#3541) - fix(icons): changed `camera` icon by [@​karsa-mistmere](https://github.com/karsa-mistmere) in [#​3539](lucide-icons/lucide#3539) - feat(icons): added `rose` icon by [@​jguddas](https://github.com/jguddas) in [#​1972](lucide-icons/lucide#1972) **Full Changelog**: <lucide-icons/lucide@0.539.0...0.540.0> </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MS44MS4wIiwidXBkYXRlZEluVmVyIjoiNDIuMTAuNSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==--> Reviewed-on: https://git.in.csmpro.ru/csmpro/csm-mapban/pulls/21 Co-authored-by: Renovate Bot <[email protected]> Co-committed-by: Renovate Bot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I missed this one in #3541
Before Submitting