-
Notifications
You must be signed in to change notification settings - Fork 399
MSC1946: Secure Secret Storage and Sharing #1946
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
63c6d03
draft of secure server-side storage
uhoreg 979827b
rename to match MSC number
uhoreg da5ce91
add sharing secrets, and a bunch of cleanups
uhoreg fee2ebf
fix typo
uhoreg 3aaf181
rename some things and add clarification
uhoreg 395d403
fix typos and make valid JSON
uhoreg d47e13c
this FIXME will be addressed in the key backup MSC
uhoreg bd9efcd
add some information and an example
uhoreg 4e2fe12
wording fixes/clarifications
uhoreg cafe49d
some clarifications
uhoreg 9aade72
make it agree with what we actually did with key requests
uhoreg 9dfca61
Apply suggestions from code review
uhoreg b27f698
more clarifications
uhoreg 86eccc3
change how we mark the default key, and make sure clients trust keys
uhoreg 4fadace
Update proposals/1946-secure_server-side_storage.md
uhoreg 5cc5908
Update proposals/1946-secure_server-side_storage.md
uhoreg e8ce135
add clarification and examples
uhoreg fc79355
make the default key event an object
uhoreg File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
add clarification and examples
- Loading branch information
commit e8ce135a411e5fa2715f9d1cbd57f0fc232bc98f
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It’s unclear how the key_id_X relates to the [key ID] above. can the json example include the event details so we can see how it looks in account_data?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
have added to the example