Firefox 75: Add loading attribute to <img> element #5862
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated data for `mozGetAsFile()` to indicate that it was deprecated in Firefox 26 and removed in 74. Source: * https://bugzilla.mozilla.org/show_bug.cgi?id=1588980 * https://www.fxsitecompat.dev/en-CA/docs/2013/htmlcanvaselement-mozgetasfile-has-been-deprecated/
This reverts commit 90728ee.
Firefox 75 adds the `<img>` attribute `loading`(and the corresponding property on `HTMLImageElement`'. Sources: * https://bugzilla.mozilla.org/show_bug.cgi?id=1542784 * https://bugzilla.mozilla.org/show_bug.cgi?id=1613611 * https://html.spec.whatwg.org/#attr-img-loading
sideshowbarker
approved these changes
Mar 24, 2020
Elchi3
reviewed
Mar 24, 2020
api/HTMLImageElement.json
Outdated
| }, | ||
| "firefox_android": { | ||
| "version_added": false, | ||
| "notes": "See <a href='https://bugzil.la/1542784'>bug 1542784</a>" |
Member
There was a problem hiding this comment.
This refers to a bug that is resolved fixed and I don't see information about Firefox Android there right away. Can you clarify why this bug reference is needed or is it the wrong bug?
Contributor
There was a problem hiding this comment.
@a2sheppy This PR is still blocked on this question, if you get a chance to take a look soon. Thank you!
Contributor
Author
There was a problem hiding this comment.
Change submitted. Sorry about that.
Removed the note from the `loading` attribute's entry for Firefox Android, as it doesn't really apply.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
loadingattribute to the HTMLImageElement pageloadingon Web performance resourcesSources: