change log.Fatal to log.Error to make subsequent os.Exit executable#189
Merged
haoel merged 1 commit intomegaease:mainfrom Aug 8, 2022
Merged
change log.Fatal to log.Error to make subsequent os.Exit executable#189haoel merged 1 commit intomegaease:mainfrom
haoel merged 1 commit intomegaease:mainfrom
Conversation
Signed-off-by: Abirdcfly <fp544037857@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #189 +/- ##
=======================================
Coverage 93.92% 93.92%
=======================================
Files 46 46
Lines 3655 3655
=======================================
Hits 3433 3433
Misses 155 155
Partials 67 67 Help us with your feedback. Take ten seconds to tell us how you rate us. |
haoel
approved these changes
Aug 8, 2022
Contributor
haoel
left a comment
There was a problem hiding this comment.
Thanks for this correction!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We use
log "github.com/sirupsen/logrus"for log package:easeprobe/cmd/easeprobe/main.go
Line 37 in 88fc4e4
And we use version 1.9 (show in go.mod)
easeprobe/go.mod
Line 17 in 88fc4e4
we use
os.Exit(-1)after line 88log.Fatallnand line 96log.FatalfFrom Fatalln doc:
So subsequent
os.Exit(-1)will not executable.Same with
log.Fatalf.So, here are 2 solutions:
option 1: just delete
os.Exit(-1);option 2: change
log.Fataltolog.ErrorI think option 2 is more appropriate.