fix: memory leak in terminal editor #279088
Merged
+4
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a memory leak in terminal editor by removing the focus listener when
clearInputis called.Before
When moving a terminal from panel to editor area 97 times, a function seems to be created each time at
terminalEditor.ts:87:64which is never removed.{ "namedFunctionCount3": [ { "count": 99, "delta": 97, "name": "anonymous", "sourceLocation": "out/vs/workbench/workbench.desktop.main.js:2841:56564", "originalLocation": "src/vs/workbench/contrib/terminal/browser/terminalEditor.ts:87:64", "originalName": "TerminalEditor.setInput" } ], "isLeak": true }After
No more leak is detected.
{ "namedFunctionCount3": [], "isLeak": false }