Skip to content

fix: memory leak in local process extension host #279351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexdima merged 5 commits into from
Dec 15, 2025
Merged

fix: memory leak in local process extension host #279351

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ffe583d
fix: memory leak in local process extension host
SimonSiefke Nov 25, 2025
8943fb1
clean
SimonSiefke Nov 25, 2025
8ba3bbe
clear promise
SimonSiefke Nov 25, 2025
55030a6
Merge branch 'main' into fix/memory-leak-local-process-extension-host
SimonSiefke Nov 25, 2025
b48a55d
Merge branch 'main' into fix/memory-leak-local-process-extension-host
alexdima Dec 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 19 additions & 19 deletions src/vs/workbench/services/extensions/electron-browser/localProcessExtensionHost.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import { timeout } from '../../../../base/common/async.js';
import { encodeBase64, VSBuffer } from '../../../../base/common/buffer.js';
import { CancellationError } from '../../../../base/common/errors.js';
import { Emitter, Event } from '../../../../base/common/event.js';
import { DisposableStore, toDisposable } from '../../../../base/common/lifecycle.js';
import { Disposable, toDisposable } from '../../../../base/common/lifecycle.js';
import * as objects from '../../../../base/common/objects.js';
import * as platform from '../../../../base/common/platform.js';
import { removeDangerousEnvVariables } from '../../../../base/common/processes.js';
Expand Down Expand Up @@ -87,18 +87,17 @@ export class ExtensionHostProcess {
}
}

export class NativeLocalProcessExtensionHost implements IExtensionHost {
export class NativeLocalProcessExtensionHost extends Disposable implements IExtensionHost {

public pid: number | null = null;
public readonly remoteAuthority = null;
public extensions: ExtensionHostExtensions | null = null;

private readonly _onExit: Emitter<[number, string]> = new Emitter<[number, string]>();
private readonly _onExit: Emitter<[number, string]> = this._register(new Emitter<[number, string]>());
public readonly onExit: Event<[number, string]> = this._onExit.event;

private readonly _onDidSetInspectPort = new Emitter<void>();
private readonly _onDidSetInspectPort = this._register(new Emitter<void>());

private readonly _toDispose = new DisposableStore();

private readonly _isExtensionDevHost: boolean;
private readonly _isExtensionDevDebug: boolean;
Expand Down Expand Up @@ -133,6 +132,7 @@ export class NativeLocalProcessExtensionHost implements IExtensionHost {
@IShellEnvironmentService private readonly _shellEnvironmentService: IShellEnvironmentService,
@IExtensionHostStarter private readonly _extensionHostStarter: IExtensionHostStarter,
) {
super();
const devOpts = parseExtensionDevOptions(this._environmentService);
this._isExtensionDevHost = devOpts.isExtensionDevHost;
this._isExtensionDevDebug = devOpts.isExtensionDevDebug;
Expand All @@ -145,27 +145,26 @@ export class NativeLocalProcessExtensionHost implements IExtensionHost {
this._extensionHostProcess = null;
this._messageProtocol = null;

this._toDispose.add(this._onExit);
this._toDispose.add(this._lifecycleService.onWillShutdown(e => this._onWillShutdown(e)));
this._toDispose.add(this._extensionHostDebugService.onClose(event => {
this._register(this._lifecycleService.onWillShutdown(e => this._onWillShutdown(e)));
this._register(this._extensionHostDebugService.onClose(event => {
if (this._isExtensionDevHost && this._environmentService.debugExtensionHost.debugId === event.sessionId) {
this._nativeHostService.closeWindow();
}
}));
this._toDispose.add(this._extensionHostDebugService.onReload(event => {
this._register(this._extensionHostDebugService.onReload(event => {
if (this._isExtensionDevHost && this._environmentService.debugExtensionHost.debugId === event.sessionId) {
this._hostService.reload();
}
}));
}

public dispose(): void {
public override dispose(): void {
if (this._terminating) {
return;
}
this._terminating = true;

this._toDispose.dispose();
super.dispose();
this._messageProtocol = null;
}

public start(): Promise<IMessagePassingProtocol> {
Expand Down Expand Up @@ -248,8 +247,8 @@ export class NativeLocalProcessExtensionHost implements IExtensionHost {

// Catch all output coming from the extension host process
type Output = { data: string; format: string[] };
const onStdout = this._handleProcessOutputStream(this._extensionHostProcess.onStdout, this._toDispose);
const onStderr = this._handleProcessOutputStream(this._extensionHostProcess.onStderr, this._toDispose);
const onStdout = this._handleProcessOutputStream(this._extensionHostProcess.onStdout);
const onStderr = this._handleProcessOutputStream(this._extensionHostProcess.onStderr);
const onOutput = Event.any(
Event.map(onStdout.event, o => ({ data: `%c${o}`, format: [''] })),
Event.map(onStderr.event, o => ({ data: `%c${o}`, format: ['color: red'] }))
Expand All @@ -263,7 +262,7 @@ export class NativeLocalProcessExtensionHost implements IExtensionHost {
}, 100);

// Print out extension host output
this._toDispose.add(onDebouncedOutput(output => {
this._register(onDebouncedOutput(output => {
const inspectorUrlMatch = output.data && output.data.match(/ws:\/\/([^\s]+):(\d+)\/([^\s]+)/);
if (inspectorUrlMatch) {
const [, host, port, auth] = inspectorUrlMatch;
Expand All @@ -286,7 +285,7 @@ export class NativeLocalProcessExtensionHost implements IExtensionHost {

// Lifecycle

this._toDispose.add(this._extensionHostProcess.onExit(({ code, signal }) => this._onExtHostProcessExit(code, signal)));
this._register(this._extensionHostProcess.onExit(({ code, signal }) => this._onExtHostProcessExit(code, signal)));

// Notify debugger that we are ready to attach to the process if we run a development extension
if (portNumber) {
Expand Down Expand Up @@ -371,9 +370,10 @@ export class NativeLocalProcessExtensionHost implements IExtensionHost {
}, 60 * 1000);

portPromise.then((port) => {
this._toDispose.add(toDisposable(() => {
this._register(toDisposable(() => {
// Close the message port when the extension host is disposed
port.close();
port.onmessage = null;
}));
clearTimeout(handle);

Expand Down Expand Up @@ -530,7 +530,7 @@ export class NativeLocalProcessExtensionHost implements IExtensionHost {
this._onExit.fire([code, signal]);
}

private _handleProcessOutputStream(stream: Event<string>, store: DisposableStore) {
private _handleProcessOutputStream(stream: Event<string>) {
let last = '';
let isOmitting = false;
const event = new Emitter<string>();
Expand Down Expand Up @@ -558,7 +558,7 @@ export class NativeLocalProcessExtensionHost implements IExtensionHost {
event.fire(line + '\n');
}
}
}, undefined, store);
}, undefined, this._store);

return event;
}
Expand Down
Loading