include uppercase -I in sed in-place option detection
#284645
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support for the uppercase -I option in sed in-place option detection, which is available on macOS and BSD systems. The change ensures that commands using sed -I are properly detected as requiring file modification operations.
Key changes:
- Updated documentation comment to include
-Ias an in-place editing option - Modified regex pattern to detect the uppercase
-Iflag alongside the existing lowercase-iflag
...rkbench/contrib/terminalContrib/chatAgentTools/common/terminalChatAgentToolsConfiguration.ts
Show resolved
Hide resolved
lszomoru
approved these changes
Dec 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
include uppercase
-Iin sed in-place option detectionThe
-Ioption is available forsedon macOS and BSDs.Although There is no official macOS manual available online, you can check by executing
man sedon macOS.ProductName: macOS
ProductVersion: 15.7.3
BuildVersion: 24G419
CC: @Tyriar