Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Jan 7, 2026

When quick suggestions are disabled (default), suggestions only appear when explicitly invoked, where the selection mode setting is less relevant and creates UI clutter.

demo.mov

Changes

Updated the when clause for three selection mode menu actions in terminal.suggest.contribution.ts:

  • ChangeSelectionModeNever
  • ChangeSelectionModePartial
  • ChangeSelectionModeAlways

Each action now includes a condition to check if automatic suggestions are enabled:

when: ContextKeyExpr.and(
    ContextKeyExpr.equals(`config.${TerminalSuggestSettingId.SelectionMode}`, '<mode>'),
    ContextKeyExpr.or(
        ContextKeyExpr.equals(`config.${TerminalSuggestSettingId.QuickSuggestions}`, true),
        ContextKeyExpr.equals(`config.${TerminalSuggestSettingId.SuggestOnTriggerCharacters}`, true),
    )
)

Behavior

  • Hidden: Both quickSuggestions and suggestOnTriggerCharacters are false (default)
  • Visible: Either setting is true
Original prompt

This section details on the original issue you should resolve

<issue_title>Do not show selectionMode in terminal suggest toolbar when quick suggestions are disabled</issue_title>
<issue_description>Idea from @Tyriar

This'll make things less confusing as now we select the suggest when explicitly invoked</issue_description>

Comments on the Issue (you are @copilot in this section)


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

…s disabled

Co-authored-by: meganrogge <29464607+meganrogge@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix selection mode display in terminal suggest toolbar Hide selection mode in terminal suggest toolbar when quick suggestions disabled Jan 7, 2026
Copilot AI requested a review from meganrogge January 7, 2026 21:59
@meganrogge meganrogge marked this pull request as ready for review January 8, 2026 19:25
Copilot AI review requested due to automatic review settings January 8, 2026 19:25
@meganrogge meganrogge added this to the January 2026 milestone Jan 8, 2026
@meganrogge meganrogge enabled auto-merge (squash) January 8, 2026 19:25
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR hides the selection mode menu items in the terminal suggest toolbar when both quick suggestions settings are disabled (their default state). This reduces UI clutter when suggestions only appear when explicitly invoked, making the selection mode setting less relevant in the default configuration.

Key Changes

  • Updated the when clause for three selection mode menu actions to include a check for whether automatic suggestions are enabled
  • Menu items now only appear when either quickSuggestions or suggestOnTriggerCharacters is set to true

@meganrogge meganrogge requested a review from Tyriar January 8, 2026 19:53
@meganrogge meganrogge merged commit e97a82b into main Jan 8, 2026
27 of 28 checks passed
@meganrogge meganrogge deleted the copilot/remove-selection-mode-toolbar branch January 8, 2026 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Do not show selectionMode in terminal suggest toolbar when quick suggestions are disabled

3 participants