Rml::UnregisterPlugin and Rml::Debugger::Shutdown #201
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikke89
approved these changes
Jul 1, 2021
Owner
mikke89
left a comment
There was a problem hiding this comment.
Thanks, makes sense to do it this way. Looks good to me!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've had to add a way to unregister a plugin, otherwise the stale plugin pointer would be used in various places. Hope that's not too much a deviation from what we talked about in #200. I've been able to use this locally and it worked very well. It may even come in handy to be able to arbitrarily unregister specific plugins in the future...