Skip to content

Conversation

@1bsyl
Copy link

@1bsyl 1bsyl commented Nov 7, 2021

for request #250
@baidwwy
I've updated the sample done for libRocket to match RmlUI sample/basics/sdl2
quickly tested.

@baidwwy
Copy link

baidwwy commented Nov 8, 2021

That’s great. Thanks

Copy link
Owner

@mikke89 mikke89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very interesting, thank you!

Not sure how to handle this with regard to the CMake list. I guess it can be a bit confusing wrt. to the old SDL2 sample. Maybe rename the old one to eg. SDL2OpenGL, and add this as a separate sample? And further we should only enable this new one after testing the SDL version, after this has had a release.

Let me know if any of you have thoughts in this regard. For now it should be perfectly fine to merge it as is (after fixing the minor suggestions), and we can work on the CMake and sample things later, cheers!

- change window title
@1bsyl
Copy link
Author

1bsyl commented Nov 11, 2021

I've just update the PR.
SDL2 is expected to be released soon, so you'll be able to try it.
Then fell free to change whatever you want.

@mikke89
Copy link
Owner

mikke89 commented Nov 11, 2021

Perfect, thanks! I'll hold on with merging until I've had a chance to test with the release of the next version of SDL2.

@mikke89 mikke89 merged commit 8577a0b into mikke89:master Dec 28, 2021
@mikke89
Copy link
Owner

mikke89 commented Dec 28, 2021

@1bsyl Thanks again! This works for me, I'm also in the process of adding CMake integration.

@aquawicket Those enhancements sounds very interesting! I'm very much looking forward to the PR(s) ;)

@mikke89
Copy link
Owner

mikke89 commented Dec 28, 2021

For reference, see also SDL2 PR libsdl-org/SDL#4195.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants