Fix robin_hood.h #335
Merged
Fix robin_hood.h #335
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates ROBIN_HOOD_IS_TRIVIALLY_COPYABLE definition due to compiler warning as error policy that makes Emscripten CI builds fail
Owner
|
Thanks! This should ideally be submitted upstream to the robin_hood library as well. I suspect this wouldn't actually work on GCC 4.x, which is the purpose of this macro guard, since it seems the new intrinsic is not supported. However, we only advertise support for GCC 5+ so it's okay for us, but something to keep in mind if you submit upstream. |
mikke89
pushed a commit
that referenced
this pull request
Aug 17, 2022
Updates ROBIN_HOOD_IS_TRIVIALLY_COPYABLE definition due to compiler warning as error policy that makes Emscripten CI builds fail (cherry picked from commit 18f65aa)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates ROBIN_HOOD_IS_TRIVIALLY_COPYABLE definition due to compiler
warning as error policy that makes Emscripten CI builds fail
Haven't checked if this actually fails on runtime or not.