Extend Element::ScrollIntoView parameters. #353
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikke89
added a commit
that referenced
this pull request
Aug 26, 2022
…ions Co-authored-by: Eugene Kozlov <[email protected]>
Owner
|
Thank you! Merged in: bd37fd2 I made some modifications, and changed some defaults to align slightly closer to the equivalent DOM function.
It's very understandable, although in the future I'd prefer not to include these for the sake of git diff/blame/conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I reasonably tested it both in UTs and in my project, I don't really feel like doing more work.
PS: I also have small personal vendetta against trailing spaces and my tools are configured to remove them automatically. I can revert these changes if I must.