Skip to content

Conversation

@shubin
Copy link
Contributor

@shubin shubin commented Nov 25, 2022

I'm embedding RmlUi into my game and it happens that the script in my game should fully manage the Rml Contexts, including input handling. I've added the input related methods to the Lua support code.

@shubin shubin closed this Nov 25, 2022
@mikke89 mikke89 added enhancement New feature or request Lua Lua binding issues labels Nov 26, 2022
@mikke89
Copy link
Owner

mikke89 commented Nov 26, 2022

Hey, and thanks for the pull request.

Did you close this on purpose? If you could fix up the CI build, then I'll happily integrate these changes. Looks like some small compatibility issues with Lua 5.2.

@shubin
Copy link
Contributor Author

shubin commented Nov 26, 2022 via email

@mikke89
Copy link
Owner

mikke89 commented Nov 27, 2022

Nice to hear you decided you want to contribute, that is very much appreciated! :)

I'm reopening this then, you can push new commits to the same branch and the build will run again. Feel free to ask if you have any questions.

@mikke89 mikke89 reopened this Nov 27, 2022
@mikke89
Copy link
Owner

mikke89 commented Nov 29, 2022

Thanks a lot, looks good to me!

It would be very helpful if you could update the API reference as well, so that others can discover this functionality;
https://mikke89.github.io/RmlUiDoc/pages/lua_manual/api_reference.html#Context

@mikke89 mikke89 merged commit cca36bf into mikke89:master Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Lua Lua binding issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants