Skip to content

Conversation

@shubin
Copy link
Contributor

@shubin shubin commented Dec 6, 2022

Add dp_ratio attribute to the Lua binding of Rml::Context providing access to its SetDensityIndependentPixelRatio and GetDensityIndependentPixelRatio methods

@mikke89 mikke89 added enhancement New feature or request Lua Lua binding issues labels Dec 7, 2022
@mikke89
Copy link
Owner

mikke89 commented Dec 7, 2022

Thanks for another Lua improvement!

This looks good to me, but is marked as a draft still, are you happy with how it looks?

The commit history is a bit messy, but I'll just squash it and then it's all good. In the future, it might be easier to create separate feature branches intended for pull requests.

@shubin shubin marked this pull request as ready for review December 7, 2022 08:54
@shubin
Copy link
Contributor Author

shubin commented Dec 7, 2022

Yeah, I've been worrying about the messy commit history as well.

The code itself is very simple. I'm not 100% sure about the naming - I've decided to name the property as "dp_ratio" and I thought that you might want to name it differently.

Thank you for your hint, will use feature branches for the future pull requests!

@mikke89
Copy link
Owner

mikke89 commented Dec 7, 2022

Yeah, I'm happy with dp_ratio as a property as long as it's documented, I think that makes the most sense.

Thanks a lot for the PR!

@shubin
Copy link
Contributor Author

shubin commented Dec 7, 2022

I'm glad that my contribution is helpful!
I will make a pull request to the documentation a bit later.

@mikke89 mikke89 merged commit fc0b04b into mikke89:master Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Lua Lua binding issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants