LuaPlugin: LuaJit support #387
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikke89
reviewed
Dec 7, 2022
Owner
mikke89
left a comment
There was a problem hiding this comment.
Thanks for the pull request!
Are you able to add a test for this to the GitHub action workflow? Either the Ubuntu or the vcpkg test for example?
Contributor
Author
|
Thanks for the review, i will fix mentioned points |
Owner
|
Hey, any update on this? |
Contributor
Author
|
hello, Yes I'm planning to fix the issue this week, I was just overloaded with everything around holidays and new year eve, sorru |
Owner
|
I understand, no worries, looking forward to seeing those changes. |
Contributor
Author
|
I've had a look on requested changes, but I'm a bit lost with adding tests to this. Could You pelase support here a little bit ? |
Owner
|
No problem, I'll take a look at it. |
Owner
|
Everything seems to be working well now, I tested it locally too. Thanks for finishing up this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LuaJit support