DataExpression: Implement ternary with jumps. #740
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoids evaluating both the true and false branch of the ternary. This can help if you are writing an expression where one side of the ternary might result in an invalid array access, e.g. read_mail_index < inbox.size ? inbox[read_mail_index].from : ''
mikke89
reviewed
Mar 17, 2025
Owner
mikke89
left a comment
There was a problem hiding this comment.
Thanks a lot, it's a very nice improvement! I guess we can say that the data expressions just became a scripting language now that we have branching, heh.
Overall looks very nice, a few minor comments.
It looks correct to me, although I would be a lot more confident if we could add some tests as well. Could you add that?
Contributor
Author
|
Added a basic test to show that only one side of the ternary gets evaluated |
Owner
|
Great stuff, looks good to me! I think the one build failure is unrelated to this PR. I'll see if I can fix it on master and then I'll merge this one. |
Owner
|
Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoids evaluating both the true and false branch of the ternary.
This can help if you are writing an expression where one side of the ternary might result in an invalid array access, e.g.
read_mail_index < inbox.size ? inbox[read_mail_index].from : inbox[1234].from