Simplification of container.getOptions#419
Merged
bingenito merged 1 commit intomorganstanley:masterfrom Feb 11, 2021
Merged
Conversation
Member
bingenito
commented
Feb 10, 2021
- Replace use of defined interface for type any to allow for support of any option across any container instead of restricting.
- Fix Electron implementation since LoginItemSettings is at the app level not electron
Codecov Report
@@ Coverage Diff @@
## master #419 +/- ##
==========================================
- Coverage 93.35% 93.34% -0.02%
==========================================
Files 16 16
Lines 1595 1592 -3
Branches 268 268
==========================================
- Hits 1489 1486 -3
Misses 106 106
|
25709df to
b51c72b
Compare
Member
Author
I removed some lines of code |
psmulovics
approved these changes
Feb 10, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.