Skip to content

Simplification of container.getOptions#419

Merged
bingenito merged 1 commit intomorganstanley:masterfrom
bingenito:getOptions-simplification
Feb 11, 2021
Merged

Simplification of container.getOptions#419
bingenito merged 1 commit intomorganstanley:masterfrom
bingenito:getOptions-simplification

Conversation

@bingenito
Copy link
Member

  • Replace use of defined interface for type any to allow for support of any option across any container instead of restricting.
  • Fix Electron implementation since LoginItemSettings is at the app level not electron

@bingenito bingenito requested a review from a team as a code owner February 10, 2021 21:38
@codecov
Copy link

codecov bot commented Feb 10, 2021

Codecov Report

Merging #419 (c47a169) into master (129233f) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #419      +/-   ##
==========================================
- Coverage   93.35%   93.34%   -0.02%     
==========================================
  Files          16       16              
  Lines        1595     1592       -3     
  Branches      268      268              
==========================================
- Hits         1489     1486       -3     
  Misses        106      106              
Impacted Files Coverage Δ
packages/desktopjs/src/desktop.ts 100.00% <ø> (ø)
packages/desktopjs-electron/src/electron.ts 97.22% <100.00%> (-0.01%) ⬇️
packages/desktopjs-openfin/src/openfin.ts 88.01% <100.00%> (-0.04%) ⬇️

@bingenito bingenito force-pushed the getOptions-simplification branch from 25709df to b51c72b Compare February 10, 2021 21:41
@bingenito
Copy link
Member Author

bingenito commented Feb 10, 2021

codecov/project — 93.34% (-0.02%) compared to 129233f

I removed some lines of code

@bingenito bingenito merged commit 923d619 into morganstanley:master Feb 11, 2021
@bingenito bingenito deleted the getOptions-simplification branch March 30, 2021 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants