Skip to content

Conversation

@manziEric
Copy link
Contributor

close: #25314

@mui-pr-bot
Copy link

mui-pr-bot commented Mar 22, 2021

Details of bundle changes

Generated by 🚫 dangerJS against 42928a5

@oliviertassinari oliviertassinari changed the title fix: update tabs Don't animate scroll on first render [Tabs] Don't animate scroll on first render Mar 22, 2021
@oliviertassinari oliviertassinari added scope: tabs Changes related to the tabs. type: new feature Expand the scope of the product to solve a new problem. labels Mar 22, 2021
@oliviertassinari
Copy link
Member

Did you have a look at the failing test case?

@manziEric
Copy link
Contributor Author

manziEric commented Mar 23, 2021

Did you have a look at the failing test case?

i have take a look at ci/circleci and did a yarn test:karma but no i have found no hint on how to solve this. Sould i edit the Tabs.test.js ?
Do you got any idee how i can solve this. and for futre pull request

Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a look at the tests, it was simply an issue with the setup. In JSDOM we were forcing a specific configuration that, once rendered in the browser, does no longer hold true. Instead, I set the right width style property.

@oliviertassinari oliviertassinari merged commit fd26749 into mui:next Mar 24, 2021
@manziEric
Copy link
Contributor Author

I had a look at the tests, it was simply an issue with the setup. In JSDOM we were forcing a specific configuration that, once rendered in the browser, does no longer hold true. Instead, I set the right width style property.

nice to hear thanks for the update. do you got any suggestions how i could test localy and find this thing for future pull requests. i like doing contributions for material ui

@oliviertassinari
Copy link
Member

do you got any suggestions how i could test locally

@manziEric It should be covered in https://github.com/mui-org/material-ui/blob/next/test/README.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope: tabs Changes related to the tabs. type: new feature Expand the scope of the product to solve a new problem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Tabs] Don't animate scroll on first render

3 participants