-
-
Notifications
You must be signed in to change notification settings - Fork 32.8k
[Tabs] Don't animate scroll on first render #25469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Did you have a look at the failing test case? |
i have take a look at ci/circleci and did a yarn test:karma but no i have found no hint on how to solve this. Sould i edit the Tabs.test.js ? |
oliviertassinari
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had a look at the tests, it was simply an issue with the setup. In JSDOM we were forcing a specific configuration that, once rendered in the browser, does no longer hold true. Instead, I set the right width style property.
nice to hear thanks for the update. do you got any suggestions how i could test localy and find this thing for future pull requests. i like doing contributions for material ui |
@manziEric It should be covered in https://github.com/mui-org/material-ui/blob/next/test/README.md |
close: #25314