-
-
Notifications
You must be signed in to change notification settings - Fork 32.8k
[docs] Add "Edit in Mui Chat" button on demos #46480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Netlify deploy previewhttps://deploy-preview-46480--material-ui.netlify.app/ Bundle size report
|
|
Linking the original one for context: mui/mui-x#17250 and clarity. The strategy to deploy this is available in: https://www.notion.so/mui-org/store-Weekly-meeting-2025-06-16-214cbfe7b66080f7a10cd3c74d5a2aa5?source=copy_link#222cbfe7b660808a9866ca671dc45b39. We are eventually adding it to all the demos. |
| data-ga-event-category="mui-chat" | ||
| data-ga-event-label={demo.gaLabel} | ||
| data-ga-event-action="open-in-mui-chat" | ||
| {...getControlProps(10)} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something strange is happing here, this button is not accessible with the keyboard like all the other controls on the toolbar.
This comment was marked as resolved.
This comment was marked as resolved.
|
What about something like this? Screen.Recording.2025-07-08.at.15.08.30.mov |
Thanks for the feedback, I think it's harder to notice. For starter I would go with a label to let user see at first glance. |
Sure, that was part of the idea, to make this new button look more in line with existing options, but make it stand out a bit more (with the gradient border). For me, the "Edit in MUI Chat" button looks out of place, like it was crammed into the current UI without considering the existing hierarchy. For me, as a user, it looks a bit messy. |
hasdfa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look good, the button in the code area looks more in place 😄
I think we may remove env variable for production Material UI docs to not show a button at start and test it only on MUI X docs, and after we would have some feedback and make it more stable add to Material UI docs. WDYT?
Yes, let's do that. |
Preview: https://deploy-preview-46480--material-ui.netlify.app/material-ui/react-button/
This PR aims to connect docs with MUI Chat. It begins with an idea to have a button on each demo that opens MUI Chat to let users extend the demo with prompts.
Screen.Recording.2568-07-15.at.08.44.21.mov