[code-infra] Remove fs-extra from docs scripts
#46749
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netlify deploy previewhttps://deploy-preview-46749--material-ui.netlify.app/ Bundle size report
|
Janpot
reviewed
Aug 15, 2025
docs/scripts/buildServiceWorker.js
Outdated
|
|
||
| await fse.copy(swSrc, swDest); | ||
| await fs.mkdir(swDestDir, { recursive: true }); | ||
| await fs.copyFile(swSrc, swDest); |
Member
There was a problem hiding this comment.
I believe fs.cp can also take file paths with recursive
Suggested change
| await fs.copyFile(swSrc, swDest); | |
| await fs.cp(swSrc, swDest, { recursive: true }); |
Member
Author
There was a problem hiding this comment.
What would the benefit be? copyFile seems more explicit as cp can be used to copy files and directories.
Member
Author
There was a problem hiding this comment.
That was my suspicion, but since it wasn't marked in the suggestion I wasn't sure. Updated 👍
Janpot
approved these changes
Aug 15, 2025
Janpot
reviewed
Aug 15, 2025
docs/scripts/buildServiceWorker.js
Outdated
|
|
||
| async function run() { | ||
| const swDest = path.join(__dirname, '../export/sw.js'); | ||
| const swDestDir = path.join(__dirname, '../export'); |
Member
There was a problem hiding this comment.
Don't really need this var anymore I guess, but not super important
fs-extra from docs scriptsfs-extra from docs scripts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of mui/mui-public#481.