Skip to content

[internal] Remove unused clean-css package from docs #20349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ZeeshanTamboli merged 10 commits into from
Nov 18, 2025
Merged

[internal] Remove unused clean-css package from docs #20349

ZeeshanTamboli merged 10 commits into from
Nov 18, 2025
+0 −12

Conversation

@ZeeshanTamboli
Copy link
Member

@ZeeshanTamboli ZeeshanTamboli commented Nov 17, 2025 •
edited
Loading

Remove clean-css like in core repo which was done in mui/material-ui#47314

@ZeeshanTamboli ZeeshanTamboli added the internal Behind-the-scenes enhancement. Formerly called “core”. label Nov 17, 2025
@ZeeshanTamboli ZeeshanTamboli changed the title [internal] Remove lz-string and markdown-to-jsx packages from docs [internal] Remove unnecessary lz-string and markdown-to-jsx packages from docs Nov 17, 2025
@mui-bot
Copy link

mui-bot commented Nov 17, 2025 •
edited
Loading

Deploy preview: https://deploy-preview-20349--material-ui-x.netlify.app/

Bundle size report

Bundle Parsed size Gzip size
@mui/x-data-grid 0B(0.00%) 0B(0.00%)
@mui/x-data-grid-pro 0B(0.00%) 0B(0.00%)
@mui/x-data-grid-premium 0B(0.00%) 0B(0.00%)
@mui/x-charts 0B(0.00%) 0B(0.00%)
@mui/x-charts-pro 0B(0.00%) 0B(0.00%)
@mui/x-charts-premium 0B(0.00%) 0B(0.00%)
@mui/x-date-pickers 0B(0.00%) 0B(0.00%)
@mui/x-date-pickers-pro 0B(0.00%) 0B(0.00%)
@mui/x-tree-view 0B(0.00%) 0B(0.00%)
@mui/x-tree-view-pro 0B(0.00%) 0B(0.00%)

Details of bundle changes

Generated by 🚫 dangerJS against 6c6ec49

@ZeeshanTamboli ZeeshanTamboli added the dependencies Update of dependencies. label Nov 17, 2025
@ZeeshanTamboli ZeeshanTamboli changed the title [internal] Remove unnecessary lz-string and markdown-to-jsx packages from docs [internal] Remove unnecessary packages from docs Nov 17, 2025
@ZeeshanTamboli ZeeshanTamboli changed the title [internal] Remove unnecessary packages from docs [internal] Remove unused packages from docs Nov 17, 2025
@ZeeshanTamboli ZeeshanTamboli marked this pull request as ready for review November 17, 2025 11:53
Janpot
Janpot requested changes Nov 17, 2025
View reviewed changes
Copy link
Member

@Janpot Janpot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

packages from core docs must be copied.

@ZeeshanTamboli
Copy link
Member Author

ZeeshanTamboli commented Nov 17, 2025

packages from core docs must be copied.

Why?

@Janpot
Copy link
Member

Janpot commented Nov 17, 2025 •
edited
Loading

Because the dependencies of core docs aren't automatically installed. core docs is not a dependency of X, only the monorepo root is.

@ZeeshanTamboli ZeeshanTamboli changed the title [internal] Remove unused packages from docs [internal] Remove unused clean-css package from docs Nov 18, 2025
@ZeeshanTamboli
Copy link
Member Author

ZeeshanTamboli commented Nov 18, 2025 •
edited
Loading

Because the dependencies of core docs aren't automatically installed. core docs is not a dependency of X, only the monorepo root is.

Okay, I thought @mui/docs is a package from core which might have these dependencies. Also, the CI didn't fail, where particularly I thought it would if markdown-to-jsx is removed.

Only removed unused clean-css package like in core repo which was done in mui/material-ui#47314

@ZeeshanTamboli ZeeshanTamboli merged commit e168ee4 into mui:master Nov 18, 2025
21 checks passed
bernardobelchior added a commit to bernardobelchior/mui-x that referenced this pull request Nov 19, 2025
@bernardobelchior
Revert "[internal] Remove unused clean-css package from docs (mui#2…
09c5a61 
…0349)"

This reverts commit e168ee4.
mapache-salvaje pushed a commit to mapache-salvaje/mui-x that referenced this pull request Dec 29, 2025
@ZeeshanTamboli @mapache-salvaje
[internal] Remove unused clean-css package from docs (mui#20349)
4af7419
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Janpot Janpot Janpot approved these changes

@LukasTy LukasTy Awaiting requested review from LukasTy

@bernardobelchior bernardobelchior Awaiting requested review from bernardobelchior

Assignees

No one assigned

Labels

dependencies Update of dependencies. internal Behind-the-scenes enhancement. Formerly called “core”.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ZeeshanTamboli @mui-bot @Janpot