profiles: ani-cli: add mpv to private-etc for plugins access #6779
Conversation
|
On that note, I would like to request addition of private-etc to mpv.profile. I don't know what exactly to allow in /etc for mpv, so it will be great if someone can figure it out. |
|
On a second thought, it is better to just add a proper private-etc to mpv.profile. This patch is just a hack until that is fixed. If a private-etc definition exists in mpv.profile, this can be reverted. |
Allow ani-cli to access /etc/mpv for mpv plugins/themes/scripts access. mpv playing under ani-cli cannot use plugins. Example: Unable to use mpv-mpris plugin when playing anime using ani-cli. This patch just adds mpv to private-etc for plugin access. The profile imports mpv.profile later so all that magic is taken care of. Note that in mpv.profile, there is no private-etc definition, but it is defined in ani-cli.profile. That's why it is broken.
Usually you can run firejail with If you could test mpv with the plugins/themes/scripts that you use, check the Example: firejail --trace=trace.txt /usr/bin/mpvFor example, IIRC yt-dlp has a path in /etc. By the way, I was working on adding the missing mpv paths (and other related
I think it's fine to merge this patch as is and then try a more encompassing |
They are currently named as "mpv". This amends commit 5dbdf65 ("new profiles: ripperx, sound-juicer", 2020-03-19). Misc: This was noticed on netblue30#6779.
Alright, ill give it a try. Also, is using |
See src/fbuilder for details. |
For simplicity and to make diffs more readable.
Use them in the remaining profiles that have `private-etc` enabled but
are not currently using private-etc groups.
Note: All of the profiles in question were created between 0.9.72 and
0.9.74 (which is when private-etc groups were introduced).
Command used to search for relevant profiles:
$ git grep '^private-etc .*alternatives' -- etc
Misc: The changes were made somewhat manually.
This is a follow-up to netblue30#6779.
Relates to netblue30#5691 netblue30#5706 netblue30#5707 netblue30#5710 netblue30#6007 netblue30#6400.
For simplicity and to make diffs more readable.
Use them in the remaining profiles that have `private-etc` enabled but
are not currently using private-etc groups.
Note: All of the profiles in question were created between 0.9.72 and
0.9.74 (which is when private-etc groups were introduced).
Command used to search for relevant profiles:
$ git grep '^private-etc .*alternatives' -- etc
Misc: The changes were made somewhat manually.
This is a follow-up to #6779.
Relates to #5691 #5706 #5707 #5710 #6007 #6400.
Allow ani-cli to access /etc/mpv for mpv plugins/themes/scripts access.
mpv playing under ani-cli cannot use plugins.
Example: Unable to use mpv-mpris plugin when playing anime using
ani-cli.
This patch just adds mpv to private-etc for plugin access.
The profile imports mpv.profile later so all that magic is taken care
of.
Note that in mpv.profile, there is no private-etc definition, but it is
defined in ani-cli.profile.
That's why it is broken.
Relates to #5707.