Auto Tagger/OCP: Disable erroneous post type tagging#2144
Open
marcustyphoon wants to merge 2 commits intonew-xkit:masterfrom
Open
Auto Tagger/OCP: Disable erroneous post type tagging#2144marcustyphoon wants to merge 2 commits intonew-xkit:masterfrom
marcustyphoon wants to merge 2 commits intonew-xkit:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This intentionally breaks Auto Tagger's by-post-type tagging due to its lack of NPF support, which currently results in it applying the tag for text posts to anything reblogged using one-click postage.
This leaves the preferences intact because it's entirely possible to hook this back up in some cases by adding a field to
XKit.interface.react.post, so someone could do that as a follow-up. (No one has seemed particularly interested in my "get rid of UI that doesn't and will never work" stuff.)If it were me I would also silently break the
keep_tagspreference and pretend it was broken by a code change, since so many people vehemently hate it, but ¯\_(ツ)_/¯