Create GA announcement, delete beta banner (don't merge until GA)! #1021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerelmiller
approved these changes
Feb 27, 2021
Contributor
|
@austin-schaefer announcement banners only display when the current date is within the supplied date range. We should be alright to merge this whenever, but I'm happy to hold off if you would like. |
jerelmiller
suggested changes
Feb 27, 2021
jerelmiller
approved these changes
Feb 27, 2021
Contributor
jerelmiller
left a comment
There was a problem hiding this comment.
As @zstix said, we can merge this whenever. It won't go live until the startDate, so we are safe to merge it now.
Contributor
Author
|
@jerelmiller @zstix : Well won't it go live at 12:01 am on March 1, hours ahead of scheduled GA? |
Contributor
|
@austin-schaefer You're right, that is true. This does use an ISO 8601 date format, so we could in theory use a time as well here. Meh, let's just wait until Monday. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tell us why
The site is GA now!
Anything else you'd like to share?
Can we set this PR to merge just before the new site goes live?