Skip to content

Conversation

@pieh
Copy link
Contributor

@pieh pieh commented May 19, 2021

Give us some context

  • What problems does this PR solve?

Fixes unexpected 404 network requests when prefetching and preloading resources for redirected pages

  • Add any context that will help us review your changes such as testing notes,
    links to related docs, screenshots, etc.

For example page ( /docs/agents/c-sdk/):

Before:
Screenshot 2021-05-19 at 17 00 38

After:
Screenshot 2021-05-19 at 16 59 55

Remaining 404 responses are not related to redirects - those 2 on this page are for:

  1. The link to image (![c-sdk-transactions1-crop.png](./images/c-sdk-transactions1-crop_1.png "c-sdk-transactions1-crop.png")) that seems to try to use gatsby-link for link (didn't investigate this part yet)
  2. this one is actually valid 404 - there's link that point to not existing page that also doesn't have redirect (/docs/insights/using-insights-ui/getting-started/introduction-new-relic-insights)
  • If your issue relates to an existing GitHub issue, please link to it.

Related to #1874 (not closing it just yet, because there are few more 404 requests happening)

Are you making a change to site code?

If you're changing site code (rather than the content of a doc), please follow
conventional commit standards
in your commit messages and pull request title.

@CLAassistant
Copy link

CLAassistant commented May 19, 2021

CLA assistant check
All committers have signed the CLA.

zstix
zstix previously approved these changes May 19, 2021
Copy link
Contributor

@zstix zstix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 This looks great, thank you!!

@zstix zstix linked an issue May 19, 2021 that may be closed by this pull request
@zstix
Copy link
Contributor

zstix commented May 19, 2021

@pieh Would you mind signing the CLA? We'd love to get this work merged in!

@jpvajda
Copy link

jpvajda commented May 19, 2021

This great @pieh We appreciate all the help here. 🚀

@pieh
Copy link
Contributor Author

pieh commented May 20, 2021

@zstix I just signed CLA and also rebased PR and fixed conflicts that showed up after #2320 was merged

@jpvajda jpvajda added the eng issues related to site functionality that requires engineering label May 22, 2021
@aswanson-nr aswanson-nr merged commit b1f48a5 into newrelic:develop May 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

eng issues related to site functionality that requires engineering

Projects

None yet

Development

Successfully merging this pull request may close these issues.

A signficant amount of Console GET failures for page-data.json requests

5 participants