-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Add missing path to create index page for "Observe Everything" #3717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This was partially documented in our style guide, but was removed in this pull request: #3670
|
@zstix that internal how to doc wasn't removed; we just created a new longer doc for it fyi. But realized I didn't add redirect for that, will do that. |
|
@zuluecho9 - are you saying this PR is not needed? Unsure what to do with this. |
|
@zuluecho9 I hate to disagree, but the content that was in that document does not exist in the repository anymore. For example, we used to have a section called "Add a new top-level nav" that no longer exists: https://github.com/newrelic/docs-website/search?q=Add+a+new+top-level+nav Same with Use nav |
|
@zstix Yes, it was dramatically restructured, mainly because the team was having trouble with it so we wanted to make it more usable for everyone. So that now that content lives in a new section here: https://docs.newrelic.com/docs/style-guide/processes-procedures/understand-edit-docs-site-structure/#add-nav-section I"m curious, too: what was your goal in wanting the category view for 'Observe everything'? Was it just to make it parallel with other categories? Or was there a problem/use case you were seeing for wanting that? |
|
@zuluecho9 At the moment, this page is blank: https://docs.newrelic.com/docs/full-stack-observability/observe-everything/ I figured that we would prefer to have some links generated to align it with how the rest of the site handles it. If this isn't desired, feel free to close out the PR! |
|
no that makes sense @zstix. Gonna approve it now. I was just curious if it was just something you noticed or if it was from a complaint or what. Thanks. I didn't state that clearly, sorry. |
|
@zuluecho9 Yeah, I noticed the issue. I do want to point out (and I apologize for being a stickler about this) that the reason this page is blank is because of a requirement that we had previously had documented that is no longer in the consolidated style guide:
|
|
@zstix Some of the 'how it works' was moved up into the more conceptual/philosophical section at top: https://docs.newrelic.com/docs/style-guide/processes-procedures/understand-edit-docs-site-structure/#doc-sidebar and this section: https://docs.newrelic.com/docs/style-guide/processes-procedures/understand-edit-docs-site-structure/#category-view I'll add a link or two from the 'create nav file' section to that 'how it works' section though. |
Description
Does what it says on the tin.
Of note, we previously had documentation for this stuff but it was recently removed.
Screenshot(s)