Why we should consider verified commits #3812
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Oh, I should have included an explanation of how I did this. The following two commands can be used to set "your" name and email: git config user.name "Someone Else"
git config user.email "their-email-or-gh-address" |
Gatsby Cloud Build Reportdocs-website-develop 🎉 Your build was successful! See the Deploy preview here. Build Details🕐 Build time: 44m |
Contributor
Author
|
I just enabled "Vigilant Mode" on my Github account. Here's a screenshot of a PR I have open (in the developer site repo) that has some verified and some unverified commits:
|
Contributor
|
Hi @zstix , cleaning out the board a bit and ran across this one. We're still tracking the docs work on this in DOC-7463 though and it's on our radar. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is a proof of concept: DO NOT MERGE.
At the moment, we don't enforce verification that whose who author a commit are actually who they say they are. For example, this PR has 4 commits:
The last commit was achieved by generating and adding a GPG key to my account and setting my git client to use that key. No one but me can have a "verified" commit.
I believe this can easily be done in Github Desktop as well.
I suggest that we consider asking core contributors to set it up. Here is some additional information about "verified" commits, including a new feature called "vigilant mode", where you're required to sign your commits.
Related Screenshot(s)