Skip to content

Conversation

@mrickard
Copy link
Contributor

Moved aws-sdk-v3 common.js requirement of semver to the getAiResponseServer function, to fix timing issue in aws-sdk-v2 versioned test failures.

…sponseServer function, to fix timing

Signed-off-by: mrickard <[email protected]>
@bizob2828 bizob2828 merged commit 6a380ef into newrelic:main Oct 23, 2025
25 checks passed
@github-project-automation github-project-automation bot moved this from Needs PR Review to Done: Issues recently completed in Node.js Engineering Board Oct 23, 2025
@codecov
Copy link

codecov bot commented Oct 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.20%. Comparing base (bbf3d01) to head (a7cd958).
⚠️ Report is 4 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (bbf3d01) and HEAD (a7cd958). Click for more details.

HEAD has 7 uploads less than BASE
Flag BASE (bbf3d01) HEAD (a7cd958)
unit-tests-22.x 1 0
unit-tests-20.x 1 0
unit-tests-24.x 1 0
integration-tests-cjs-22.x 1 0
integration-tests-cjs-20.x 1 0
integration-tests-cjs-24.x 1 0
integration-tests-esm-24.x 1 0
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #3461       +/-   ##
===========================================
- Coverage   97.77%   81.20%   -16.58%     
===========================================
  Files         413      403       -10     
  Lines       55018    53997     -1021     
  Branches        1        1               
===========================================
- Hits        53795    43847     -9948     
- Misses       1223    10150     +8927     
Flag Coverage Δ
integration-tests-cjs-20.x ?
integration-tests-cjs-22.x ?
integration-tests-cjs-24.x ?
integration-tests-esm-20.x 51.89% <ø> (-0.08%) ⬇️
integration-tests-esm-22.x 51.94% <ø> (-0.08%) ⬇️
integration-tests-esm-24.x ?
unit-tests-20.x ?
unit-tests-22.x ?
unit-tests-24.x ?
versioned-tests-20.x 81.05% <ø> (-0.28%) ⬇️
versioned-tests-22.x 81.06% <ø> (-0.28%) ⬇️
versioned-tests-24.x 80.99% <ø> (-0.28%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bizob2828 bizob2828 added the dev:tests Indicates only changes to tests label Oct 23, 2025
@github-actions github-actions bot mentioned this pull request Oct 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dev:tests Indicates only changes to tests

Projects

Status: Done: Issues recently completed

Development

Successfully merging this pull request may close these issues.

2 participants