Skip to content

Conversation

@kb-newrelic
Copy link
Contributor

@kb-newrelic kb-newrelic commented Sep 25, 2025

Summary

Tests

  • Remove unused values from nr_backend char
  • Changed terminology of deploy_id to test_key as that is the context the value is used in now.
  • Cleaned up some method naming that was still tied to us using the hostname (instead of the testKey) as identifier for telemetry

CI / Makefiles

  • Avoid unnecessary source generation in licenses-check by checking for existence of _build. Solving this with target dependencies would've required to make generate-sources aware of all its dependencies. While that's possible, it's also a big risk for this to get outdated over time, potentially leading to unintentionally skipping source generation, so I decided to keep it a phony target for now.
  • Restructure Makefile as we've shifted the compilation completely to goreleaser.
    • distro-specific targets contain the distro in the target name to distinguish them from general targets. Some general targets are just delegations to distro-specific targets
    • remove build targets, only generate-sources-... remain
    • add pre/post-sourcegen-targets to make that distinction in checks clear
    • mark phony targets as actual phony
    • remove unused generate target
    • add clean targets
  • Fix ensure-goreleaser-up-to-date as it wasn't checking for all goreleaser files (nightly fips was actually outdated)

schedule:
# Scheduled to run in the morning (PT) on every day-of-week from Monday through Friday.
- cron: '0 15 * * 1-5'
- cron: '0 10 * * 1-5'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With east coast team members, we want this running a bit earlier.
Should also move the nightly fips workflow up once merged.

@kb-newrelic kb-newrelic changed the title refactor: update outdated terminology refactor: cleanup inconsistencies Sep 25, 2025
@kb-newrelic kb-newrelic changed the title refactor: cleanup inconsistencies refactor: cleanup CI inconsistencies Sep 26, 2025
@kb-newrelic kb-newrelic force-pushed the kbauer/cleanup-legacy-terminology branch from 2747a7f to 177aa24 Compare October 1, 2025 23:37
@kb-newrelic kb-newrelic marked this pull request as ready for review October 1, 2025 23:52
@kb-newrelic kb-newrelic requested a review from a team as a code owner October 1, 2025 23:52
@kb-newrelic kb-newrelic force-pushed the kbauer/cleanup-legacy-terminology branch 2 times, most recently from 878ea4e to ab111d2 Compare October 2, 2025 19:06
@kb-newrelic kb-newrelic force-pushed the kbauer/cleanup-legacy-terminology branch from 15b409d to f473335 Compare October 14, 2025 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants