refactor: cleanup CI inconsistencies #401
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Tests
nr_backendchardeploy_idtotest_keyas that is the context the value is used in now.CI / Makefiles
licenses-checkby checking for existence of_build. Solving this with target dependencies would've required to makegenerate-sourcesaware of all its dependencies. While that's possible, it's also a big risk for this to get outdated over time, potentially leading to unintentionally skipping source generation, so I decided to keep it a phony target for now.buildtargets, onlygenerate-sources-...remainpre/post-sourcegen-targetsto make that distinction in checks cleargeneratetargetensure-goreleaser-up-to-dateas it wasn't checking for all goreleaser files (nightly fips was actually outdated)