Skip to content

Conversation

@tobiasKaminsky
Copy link
Member

ChunkedUpload should also be able to overwrite files.
This is a responsibility of client to check this.

Signed-off-by: tobiasKaminsky tobias@kaminsky.me

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@tobiasKaminsky
Copy link
Member Author

/backport to stable-1.3

@nextcloud-android-bot
Copy link
Collaborator

Lint

TypemasterPR
Warnings00
Errors00

FindBugs (new)

Warning TypeNumber
Bad practice Warnings14
Correctness Warnings38
Internationalization Warnings5
Malicious code vulnerability Warnings7
Multithreaded correctness Warnings3
Performance Warnings19
Security Warnings29
Dodgy code Warnings85
Total200

FindBugs (master)

Warning TypeNumber
Bad practice Warnings14
Correctness Warnings38
Internationalization Warnings5
Malicious code vulnerability Warnings7
Multithreaded correctness Warnings3
Performance Warnings19
Security Warnings29
Dodgy code Warnings85
Total200

@codecov
Copy link

codecov bot commented Mar 7, 2019

Codecov Report

Merging #258 into master will not change coverage.
The diff coverage is 0%.

@@           Coverage Diff           @@
##           master     #258   +/-   ##
=======================================
  Coverage   12.35%   12.35%           
=======================================
  Files         120      120           
  Lines        5295     5295           
  Branches      738      738           
=======================================
  Hits          654      654           
  Misses       4535     4535           
  Partials      106      106
Impacted Files Coverage Δ
...ources/files/ChunkedFileUploadRemoteOperation.java 23.58% <0%> (ø) ⬆️

1 similar comment
@codecov
Copy link

codecov bot commented Mar 7, 2019

Codecov Report

Merging #258 into master will not change coverage.
The diff coverage is 0%.

@@           Coverage Diff           @@
##           master     #258   +/-   ##
=======================================
  Coverage   12.35%   12.35%           
=======================================
  Files         120      120           
  Lines        5295     5295           
  Branches      738      738           
=======================================
  Hits          654      654           
  Misses       4535     4535           
  Partials      106      106
Impacted Files Coverage Δ
...ources/files/ChunkedFileUploadRemoteOperation.java 23.58% <0%> (ø) ⬆️

@backportbot-nextcloud
Copy link

backport to stable-1.3 in #259

@AndyScherzinger AndyScherzinger deleted the overwriteFile branch March 7, 2019 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants