Fix tasks.svg (Qt QML: Unsupported image format) #805
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
This is required for nice visual representation with nextcloud/desktop#1565 inside the desktop client, so backporting would be nice @raimund-schluessler |
nickvergessen
approved these changes
Jan 17, 2020
Codecov Report
@@ Coverage Diff @@
## master #805 +/- ##
==========================================
+ Coverage 26.63% 74.54% +47.9%
==========================================
Files 44 8 -36
Lines 2140 110 -2030
Branches 395 0 -395
==========================================
- Hits 570 82 -488
+ Misses 1445 28 -1417
+ Partials 125 0 -125 |
Member
|
Fine with me, @misch7 could you just sign-off your commit, please? @nickvergessen Tasks currently supports Nextcloud down to 15, so the next version should cover everything. |
Member
|
The change is small enough to not qualify for signoff requirement |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.