Skip to content

Conversation

@sbethur
Copy link
Contributor

@sbethur sbethur commented Mar 6, 2020

- [ ] I've added tests applicable for this pull request

What does this Pull Request accomplish?

Release the following:

  • nitclk 1.0
  • nidigital 0.5
  • nidcpower 1.2
  • nidmm 1.2
  • nifgen 1.2
  • nimodinst 1.2
  • niscope 1.2
  • nise 1.2
  • niswitch 1.2

List issues fixed by this Pull Request below, if any.

None

What testing has been done?

Unit and system tests

@sbethur sbethur requested a review from marcoskirsch March 6, 2020 23:22
@codecov
Copy link

codecov bot commented Mar 6, 2020

Codecov Report

Merging #1313 into master will decrease coverage by 3.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1313      +/-   ##
==========================================
- Coverage   91.48%   88.41%   -3.07%     
==========================================
  Files          20       31      +11     
  Lines        3604     6991    +3387     
==========================================
+ Hits         3297     6181    +2884     
- Misses        307      810     +503     
Flag Coverage Δ
#codegenunittests 87.76% <ø> (ø)
#nidcpowersystemtests 98.58% <ø> (?)
#nidigitalsystemtests 56.51% <ø> (?)
#nidmmsystemtests 95.48% <ø> (?)
#nifakeunittests 96.18% <100.00%> (ø)
#nifgensystemtests 96.91% <ø> (?)
#nimodinstsystemtests 87.23% <ø> (?)
#nimodinstunittests 96.08% <100.00%> (ø)
#niscopesystemtests 83.15% <ø> (?)
#nisesystemtests 100.00% <ø> (?)
#niswitchsystemtests 98.11% <ø> (?)
#nitclksystemtests 100.00% <ø> (?)
#nitclkunittests 96.00% <100.00%> (ø)
Impacted Files Coverage Δ
generated/niswitch/niswitch/_library.py 98.11% <0.00%> (ø)
generated/nifgen/nifgen/_library.py 96.91% <0.00%> (ø)
generated/nise/nise/_library.py 100.00% <0.00%> (ø)
generated/niscope/niscope/_library.py 86.69% <0.00%> (ø)
generated/nitclk/nitclk/_library.py 100.00% <0.00%> (ø)
...digital/nidigital/history_ram_cycle_information.py 100.00% <0.00%> (ø)
generated/nimodinst/nimodinst/_library.py 87.23% <0.00%> (ø)
generated/nidmm/nidmm/_library.py 95.48% <0.00%> (ø)
generated/niscope/niscope/waveform_info.py 57.35% <0.00%> (ø)
generated/nidigital/nidigital/_library.py 54.84% <0.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 601b602...9c72cae. Read the comment docs.

sbethur added 2 commits March 6, 2020 17:51
Update nidigital to 0.4
Update examples.rst
@sbethur sbethur requested a review from marcoskirsch March 7, 2020 00:09
@sbethur sbethur dismissed marcoskirsch’s stale review March 7, 2020 00:09

Addressed comments

========

`You can download all niswitch examples here <https://github.com/ni/nimi-python/releases/download/1.1.5/niswitch_examples.zip>`_
`You can download all niswitch examples here <https://github.com/ni/nimi-python/releases/download/1.2.0/niswitch_examples.zip>`_
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we'll have to test this link once the artifacts are published.

@sbethur sbethur changed the title [DO NOT MERGE] Release nitclk 1.0, nidigital 0.5, and 1.2 of other modules Release nitclk 1.0, nidigital 0.5, and 1.2 of other modules Mar 7, 2020
@sbethur sbethur merged commit 8636b8b into master Mar 7, 2020
@sbethur sbethur deleted the release_1_2 branch March 7, 2020 00:25
@sbethur sbethur changed the title Release nitclk 1.0, nidigital 0.5, and 1.2 of other modules Release nitclk 1.0, nidigital 0.4, and 1.2 of other modules Apr 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants