Skip to content

Conversation

@sbethur
Copy link
Contributor

@sbethur sbethur commented Sep 18, 2020

- [ ] I've added tests applicable for this pull request

What does this Pull Request accomplish?

Release nidigital 0.9.2 and 1.3.2 of other modules. See CHANGELOG for list of changes.

List issues fixed by this Pull Request below, if any.

None

What testing has been done?

Visual inspection of modified files, unit tests. nimi-bot will run system tests.

@codecov
Copy link

codecov bot commented Sep 18, 2020

Codecov Report

Merging #1522 into master will increase coverage by 2.21%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1522      +/-   ##
==========================================
+ Coverage   91.66%   93.88%   +2.21%     
==========================================
  Files          20       32      +12     
  Lines        3457     6851    +3394     
==========================================
+ Hits         3169     6432    +3263     
- Misses        288      419     +131     
Flag Coverage Δ
#codegenunittests 88.27% <ø> (ø)
#nidcpowersystemtests 98.58% <ø> (?)
#nidigitalsystemtests 96.91% <ø> (?)
#nidmmsystemtests 95.48% <ø> (?)
#nifakeunittests 96.34% <100.00%> (ø)
#nifgensystemtests 96.91% <ø> (?)
#nimodinstsystemtests 87.23% <ø> (?)
#nimodinstunittests 95.37% <ø> (ø)
#niscopesystemtests 91.26% <ø> (?)
#nisesystemtests 100.00% <ø> (?)
#niswitchsystemtests 98.11% <ø> (?)
#nitclksystemtests 100.00% <ø> (?)
#nitclkunittests 95.61% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
generated/nifake/nifake/__init__.py 83.33% <100.00%> (ø)
generated/nise/nise/_library.py 100.00% <0.00%> (ø)
generated/niscope/niscope/_library.py 95.17% <0.00%> (ø)
generated/nidmm/nidmm/_library.py 95.48% <0.00%> (ø)
generated/nidigital/nidigital/_library.py 96.77% <0.00%> (ø)
generated/nitclk/nitclk/_library.py 100.00% <0.00%> (ø)
...digital/nidigital/history_ram_cycle_information.py 100.00% <0.00%> (ø)
generated/niscope/niscope/measurement_stats.py 100.00% <0.00%> (ø)
generated/niscope/niscope/waveform_info.py 64.19% <0.00%> (ø)
generated/niswitch/niswitch/_library.py 98.11% <0.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98698a8...c0ecbf6. Read the comment docs.

@sbethur
Copy link
Contributor Author

sbethur commented Sep 18, 2020

test this please

@marcoskirsch
Copy link
Member

Lots of system tests failed.

@marcoskirsch
Copy link
Member

Looks like the tests ran ok, but something went wrong afterwards:

java.io.EOFException
	at java.io.ObjectInputStream$PeekInputStream.readFully(Unknown Source)
	at java.io.ObjectInputStream$BlockDataInputStream.readShort(Unknown Source)
	at java.io.ObjectInputStream.readStreamHeader(Unknown Source)
	at java.io.ObjectInputStream.<init>(Unknown Source)
	at hudson.remoting.ObjectInputStreamEx.<init>(ObjectInputStreamEx.java:49)
	at hudson.remoting.Command.readFrom(Command.java:140)
	at hudson.remoting.Command.readFrom(Command.java:126)
	at hudson.remoting.AbstractSynchronousByteArrayCommandTransport.read(AbstractSynchronousByteArrayCommandTransport.java:35)
	at hudson.remoting.SynchronousCommandTransport$ReaderThread.run(SynchronousCommandTransport.java:63)
Caused: java.io.IOException: Unexpected termination of the channel
	at hudson.remoting.SynchronousCommandTransport$ReaderThread.run(SynchronousCommandTransport.java:77)
Caused: java.io.IOException: Backing channel 'nimibot-win-64-1' is disconnected.
	at hudson.remoting.RemoteInvocationHandler.channelOrFail(RemoteInvocationHandler.java:214)
	at hudson.remoting.RemoteInvocationHandler.invoke(RemoteInvocationHandler.java:283)
	at com.sun.proxy.$Proxy81.isAlive(Unknown Source)
	at hudson.Launcher$RemoteLauncher$ProcImpl.isAlive(Launcher.java:1150)
	at hudson.Launcher$RemoteLauncher$ProcImpl.join(Launcher.java:1142)
	at hudson.tasks.CommandInterpreter.join(CommandInterpreter.java:155)
	at hudson.tasks.CommandInterpreter.perform(CommandInterpreter.java:109)
	at hudson.tasks.CommandInterpreter.perform(CommandInterpreter.java:66)
	at hudson.tasks.BuildStepMonitor$1.perform(BuildStepMonitor.java:20)
	at hudson.model.AbstractBuild$AbstractBuildExecution.perform(AbstractBuild.java:741)
	at hudson.model.Build$BuildExecution.build(Build.java:206)
	at hudson.model.Build$BuildExecution.doRun(Build.java:163)
	at hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:504)
	at hudson.model.Run.execute(Run.java:1853)
	at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
	at hudson.model.ResourceController.execute(ResourceController.java:97)
	at hudson.model.Executor.run(Executor.java:427)
FATAL: Unable to delete script file C:\Users\Administrator\AppData\Local\Temp\jenkins4675973596674486110.bat
java.io.EOFException
	at java.io.ObjectInputStream$PeekInputStream.readFully(Unknown Source)
	at java.io.ObjectInputStream$BlockDataInputStream.readShort(Unknown Source)
	at java.io.ObjectInputStream.readStreamHeader(Unknown Source)
	at java.io.ObjectInputStream.<init>(Unknown Source)
	at hudson.remoting.ObjectInputStreamEx.<init>(ObjectInputStreamEx.java:49)
	at hudson.remoting.Command.readFrom(Command.java:140)
	at hudson.remoting.Command.readFrom(Command.java:126)
	at hudson.remoting.AbstractSynchronousByteArrayCommandTransport.read(AbstractSynchronousByteArrayCommandTransport.java:35)
	at hudson.remoting.SynchronousCommandTransport$ReaderThread.run(SynchronousCommandTransport.java:63)
Caused: java.io.IOException: Unexpected termination of the channel
	at hudson.remoting.SynchronousCommandTransport$ReaderThread.run(SynchronousCommandTransport.java:77)
Caused: hudson.remoting.ChannelClosedException: Channel "hudson.remoting.Channel@66820c:nimibot-win-64-1": Remote call on nimibot-win-64-1 failed. The channel is closing down or has closed down
	at hudson.remoting.Channel.call(Channel.java:948)
	at hudson.FilePath.act(FilePath.java:1069)
	at hudson.FilePath.act(FilePath.java:1058)
	at hudson.FilePath.delete(FilePath.java:1539)
	at hudson.tasks.CommandInterpreter.perform(CommandInterpreter.java:123)
	at hudson.tasks.CommandInterpreter.perform(CommandInterpreter.java:66)
	at hudson.tasks.BuildStepMonitor$1.perform(BuildStepMonitor.java:20)
	at hudson.model.AbstractBuild$AbstractBuildExecution.perform(AbstractBuild.java:741)
	at hudson.model.Build$BuildExecution.build(Build.java:206)
	at hudson.model.Build$BuildExecution.doRun(Build.java:163)
	at hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:504)
	at hudson.model.Run.execute(Run.java:1853)
	at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
	at hudson.model.ResourceController.execute(ResourceController.java:97)
	at hudson.model.Executor.run(Executor.java:427)
Build step 'Execute Windows batch command' marked build as failure
ERROR: Step ‘Publish JUnit test result report’ failed: no workspace for nimi-bot/win64/nidcpower #740
Adding one-line test results to commit status...
Setting status of c0ecbf6984cb8b18f2bbf0738a480aae5c32790b to FAILURE with url http://nimibot-jenkins.amer.corp.natinst.com:8080/job/nimi-bot/job/win64/job/nidcpower/740/ and message: 'Failure!
 No test results found.'
Using context: system-tests/win64/nidcpower
Finished: FAILURE

@sbethur
Copy link
Contributor Author

sbethur commented Sep 18, 2020

Lots of system tests failed.

Yeah, connectivity issue on win64 node:

Channel "hudson.remoting.Channel@66820c:nimibot-win-64-1": Remote call on nimibot-win-64-1 failed. The channel is closing down or has closed down

I've re-kicked the tests.

@sbethur
Copy link
Contributor Author

sbethur commented Sep 18, 2020

All the tests pass now. I've seen this issue before, but it's too intermittent to reproduce and debug.

@sbethur sbethur changed the title [DO NOT MERGE] Release nidigital 0.9.2 and 1.3.2 of other modules Release nidigital 0.9.2 and 1.3.2 of other modules Sep 18, 2020
@sbethur sbethur merged commit 758e7a0 into master Sep 18, 2020
@sbethur sbethur deleted the release_1_3_2 branch September 18, 2020 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants