Skip to content

chore(optimiser): Move out of beta#4309

Open
thejus03 wants to merge 13 commits intonusmodifications:masterfrom
thejus03:thejus/remove_beta
Open

chore(optimiser): Move out of beta#4309
thejus03 wants to merge 13 commits intonusmodifications:masterfrom
thejus03:thejus/remove_beta

Conversation

@thejus03
Copy link
Contributor

Context

Implementation

@vercel
Copy link

vercel bot commented Feb 21, 2026

@thejus03 is attempting to deploy a commit to the modsbot's projects Team on Vercel.

A member of the Team first needs to authorize it.

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Feb 21, 2026

PR author is not in the allowed authors list.

@thejus03 thejus03 changed the title Thejus/remove beta chore(optimiser): Move out of beta Feb 21, 2026
@codecov
Copy link

codecov bot commented Feb 21, 2026

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 56.65%. Comparing base (988c6fd) to head (53fbef6).
⚠️ Report is 208 commits behind head on master.

Files with missing lines Patch % Lines
...iserBetaNotification/OptimiserBetaNotification.tsx 0.00% 2 Missing ⚠️
website/src/views/settings/BetaToggle.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4309      +/-   ##
==========================================
+ Coverage   54.52%   56.65%   +2.12%     
==========================================
  Files         274      309      +35     
  Lines        6076     6962     +886     
  Branches     1455     1680     +225     
==========================================
+ Hits         3313     3944     +631     
- Misses       2763     3018     +255     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vercel
Copy link

vercel bot commented Mar 8, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Actions Updated (UTC)
nusmods-export Ignored Ignored Preview Mar 9, 2026 0:16am
nusmods-website Ignored Ignored Preview Mar 9, 2026 0:16am

Request Review

Copy link
Member

@jloh02 jloh02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @thejus03 maybe following the prerequisite beta workflow, instead of a feature flag, it'd be good to have

  1. a banner at the top that says the optimizer is still being tested as a beta
  2. buttons on the banner to report issue on GitHub + Telegram group

this is so we can track potential launch issues better

@thejus03
Copy link
Contributor Author

thejus03 commented Mar 8, 2026

Sure! I have implemented a possible design (as seen below). Its mostly following the same notification shown in the timetable page.

On desktop
image

On mobile
image

@thejus03 thejus03 requested a review from jloh02 March 8, 2026 16:27
@jloh02
Copy link
Member

jloh02 commented Mar 9, 2026

My bad, realized it was a bit clunky. So removed the alert and made it leaner with just the buttons you implemented. Can lmk your thoughts @thejus03

Clipboard_Screenshot_1773025589 Clipboard_Screenshot_1773025530 Clipboard_Screenshot_1773025544

@thejus03
Copy link
Contributor Author

thejus03 commented Mar 9, 2026

Looks good!

@jloh02
Copy link
Member

jloh02 commented Mar 9, 2026

Great! We will merge this once CPEx is over and pending the #4340

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants