fix: replace missing component in override with inline definition#475
fix: replace missing component in override with inline definition#475
Conversation
|
👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with |
|
This is blocking octokit/types.ts#658. I simply took the definition from the |
|
After checking https://github.com/github/rest-api-description/blob/main/descriptions/api.github.com/api.github.com.json I see the Does this mean we should remove it completely instead? ...or open an issue in https://github.com/github/rest-api-description? |
|
I added it back to avoid a breaking change in order to at least get v17 changes published. |
|
🎉 This PR is included in version 17.1.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Resolves #ISSUE_NUMBER
Before the change?
After the change?
Pull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!