Introduce app click events #2070

breedx-splk · 2025-04-08T22:25:37Z

Changes

This introduces two new click event definitions:

app.screen.click - for a user clicking somewhere on a screen
app.widget.click - for a user clicking on a GUI widget

The docs/app/app.md file is net new (didn't exist previously).

Merge requirement checklist

CONTRIBUTING.md guidelines followed.
Change log entry added, according to the guidelines in When to add a changelog entry.
- If your PR does not need a change log, start the PR title with [chore]
schema-next.yaml updated with changes to existing conventions.

cleverchuk

LTGM except that app.widget.id and app.widget.name have same description throughout. It looks like it was intentional?

LikeTheSalad

Cheers!

docs/app/app.md

model/app/registry.yaml

breedx-splk · 2025-04-09T16:07:21Z

LTGM except that app.widget.id and app.widget.name have same description throughout. It looks like it was intentional?

Yeah, so there are two separate fields per attribute -- the brief and the note. Correct me if I'm wrong, but I believe that the brief is intended to be a short description, typically one or two short sentences. The note is there to provide additional clarity/explanation. I thought it important to note what a widget is, because there isn't a lot of prior art in semconv so far.

If you feel like it's too redundant or if we can consolidate that somewhere else, I'm open to suggestions.

trask

blocking temporarily to discuss whether we can unify screen coordinate representation with #1941

I've added this topic to next week's client instrumentation SIG meeting agenda

bidetofevil

LGTM. Additional attributes suggested can be added later on.

docs/app/app.md

trask · 2025-04-18T14:23:22Z

blocking temporarily to discuss whether we can unify screen coordinate representation with #1941

See #2145

Guidance provided in #2145

docs/app/app.md

Co-authored-by: Liudmila Molkova <[email protected]>

docs/app/app.md

model/app/registry.yaml

…coordinate to be a 2 element array with xy in the key name.

model/app/registry.yaml

jsuereth · 2025-04-28T16:35:49Z

I'm blocking this PR until #2070 (comment) is resolved.

breedx-splk · 2025-04-28T20:25:14Z

Thanks @jsuereth. To clarify for the record, and because this is my PR, I definitely prefer having separate fields for x and y. I made a concession and agreed to do the array thing purely as an attempt to move this new experimental spec forward.

I believe that it's probably a mistake to try and micro-optimize at this level, especially before any usage has been established.

…nge the coordinate to be a 2 element array with xy in the key name." This reverts commit 8ad7997.

breedx-splk · 2025-04-29T16:59:27Z

Based on the above and today's client SIG, I've reverted the last commit to better adhere to the existing guidance.

jsuereth

My concerns are now resolved, thanks!

Co-authored-by: Liudmila Molkova <[email protected]>

- Generate the new `semconv/v1.33.0` package and all sub-packages - Fix the metric util package generation to support `int64` attribute definitions ## [`v1.33.0` semantic convention release notes](https://github.com/open-telemetry/semantic-conventions/releases/tag/v1.33.0): <div data-pjax="true" data-test-selector="body-content" data-view-component="true" class="markdown-body my-3"><p>This release marks the first where the core of database semantic conventions have stabilized.</p> <h3>🛑 Breaking changes 🛑</h3> <ul> <li><code>db</code>: Add <code>db.query.parameter</code>, replace relevant usages of <code>db.operation.parameter</code> (<a href="open-telemetry/semantic-conventions#2093" data-hovercard-type="pull_request" data-hovercard-url="/open-telemetry/semantic-conventions/pull/2093/hovercard">#2093</a>)</li> <li><code>db</code>: Make <code>db.response.returned_rows</code> opt-in on <code>release_candidate</code> spans (<a href="open-telemetry/semantic-conventions#2211" data-hovercard-type="pull_request" data-hovercard-url="/open-telemetry/semantic-conventions/pull/2211/hovercard">#2211</a>)</li> <li><code>db</code>: Use <code>|</code> as the separator when <code>db.namespace</code> is a concatenation of multiple components. (<a href="open-telemetry/semantic-conventions#2067" data-hovercard-type="issue" data-hovercard-url="/open-telemetry/semantic-conventions/issues/2067/hovercard">#2067</a>)</li> <li><code>feature_flag</code>: Rename <code>feature_flag.provider_name</code> to <code>feature_flag.provider.name</code> (<a href="open-telemetry/semantic-conventions#1982" data-hovercard-type="pull_request" data-hovercard-url="/open-telemetry/semantic-conventions/pull/1982/hovercard">#1982</a>)</li> <li><code>feature_flag</code>: Use generic <code>error.message</code> in feature flag evaluation event (<a href="open-telemetry/semantic-conventions#1994" data-hovercard-type="pull_request" data-hovercard-url="/open-telemetry/semantic-conventions/pull/1994/hovercard">#1994</a>)</li> <li><code>gen-ai</code>: Refine the values for <code>gen_ai.system</code> related to Google's AI endpoints. (<a href="open-telemetry/semantic-conventions#1950" data-hovercard-type="issue" data-hovercard-url="/open-telemetry/semantic-conventions/issues/1950/hovercard">#1950</a>)<br> Enable sharing of attributes between Vertex AI and Gemini through a common prefix.</li> <li><code>k8s</code>: Make k8s Node and Pod labels optional (<a href="open-telemetry/semantic-conventions#2079" data-hovercard-type="issue" data-hovercard-url="/open-telemetry/semantic-conventions/issues/2079/hovercard">#2079</a>)</li> <li><code>otel</code>: Rename span health metrics to remove the .count suffixes (<a href="open-telemetry/semantic-conventions#1979" data-hovercard-type="issue" data-hovercard-url="/open-telemetry/semantic-conventions/issues/1979/hovercard">#1979</a>)</li> </ul> <h3>🚀 New components 🚀</h3> <ul> <li><code>db</code>: Adding semantic conventions for <code>oracledb</code> instrumentations. (<a href="https://github.com/open-telemetry/semantic-conventions/issues/2612">#2612</a>)<br> Oracle Database semantic conventions.</li> <li><code>browser</code>: Add browser web vitals event. (<a href="open-telemetry/semantic-conventions#1940" data-hovercard-type="pull_request" data-hovercard-url="/open-telemetry/semantic-conventions/pull/1940/hovercard">#1940</a>)</li> </ul> <h3>💡 Enhancements 💡</h3> <ul> <li><code>cicd</code>: Add resource conventions for CICD systems and define spans for CICD pipeline runs. (<a href="open-telemetry/semantic-conventions#1713" data-hovercard-type="issue" data-hovercard-url="/open-telemetry/semantic-conventions/issues/1713/hovercard">#1713</a>)<br> Define spans <code>cicd.pipeline.run.server</code> and <code>cicd.pipeline.task.internal</code>.<br> Add <code>cicd.pipeline.action.name</code>, <code>cicd.worker.id</code>, <code>cicd.worker.name</code>, <code>cicd.worker.url.full</code> and<code>cicd.pipeline.task.run.result</code> to attribute registry.<br> Define resources <code>cicd.pipeline</code>, <code>cicd.pipeline.run</code> and <code>cicd.worker</code>.<br> Add entity associations in cicd metrics for these new cicd resources.</li> <li><code>vcs</code>: Add resource conventions for VCS systems and VCS references. (<a href="open-telemetry/semantic-conventions#1713" data-hovercard-type="issue" data-hovercard-url="/open-telemetry/semantic-conventions/issues/1713/hovercard">#1713</a>)<br> Define resources <code>vcs.repo</code> and <code>vcs.ref</code>.<br> Add entity associations in vcs metrics for these new vcs resources.</li> <li><code>gen-ai</code>: Adding span for invoke agent (<a href="open-telemetry/semantic-conventions#1842" data-hovercard-type="issue" data-hovercard-url="/open-telemetry/semantic-conventions/issues/1842/hovercard">#1842</a>)</li> <li><code>gen-ai</code>: Adding gen_ai.tool.description to the span attributes (<a href="open-telemetry/semantic-conventions#2087" data-hovercard-type="issue" data-hovercard-url="/open-telemetry/semantic-conventions/issues/2087/hovercard">#2087</a>)</li> <li><code>gen-ai</code>: Separate inference and embeddings span definitions, remove irrelevant attributes from the create agent span. (<a href="open-telemetry/semantic-conventions#1924" data-hovercard-type="issue" data-hovercard-url="/open-telemetry/semantic-conventions/issues/1924/hovercard">#1924</a>, <a href="open-telemetry/semantic-conventions#2122" data-hovercard-type="pull_request" data-hovercard-url="/open-telemetry/semantic-conventions/pull/2122/hovercard">#2122</a>)</li> <li><code>general</code>: Provide guidance on modeling lat/lon, x/y, etc (<a href="open-telemetry/semantic-conventions#2145" data-hovercard-type="pull_request" data-hovercard-url="/open-telemetry/semantic-conventions/pull/2145/hovercard">#2145</a>)</li> <li><code>db</code>: Move <code>db.query.parameter.<key></code> from release_candidate back to development. (<a href="open-telemetry/semantic-conventions#2194" data-hovercard-type="pull_request" data-hovercard-url="/open-telemetry/semantic-conventions/pull/2194/hovercard">#2194</a>)</li> <li><code>db</code>: Mark database semantic conventions as stable for MariaDB, Microsoft SQL Server, MySQL, and PostgreSQL. (<a href="open-telemetry/semantic-conventions#2199" data-hovercard-type="pull_request" data-hovercard-url="/open-telemetry/semantic-conventions/pull/2199/hovercard">#2199</a>)</li> <li><code>db</code>: Make <code>db.operation.name</code> required where it's available, add recommendation for instrumentation point. (<a href="open-telemetry/semantic-conventions#2200" data-hovercard-type="pull_request" data-hovercard-url="/open-telemetry/semantic-conventions/pull/2200/hovercard">#2200</a>, <a href="open-telemetry/semantic-conventions#2098" data-hovercard-type="issue" data-hovercard-url="/open-telemetry/semantic-conventions/issues/2098/hovercard">#2098</a>)</li> <li><code>db</code>: Add <code>db.stored_procedure.name</code> to the general span conventions (<a href="open-telemetry/semantic-conventions#2205" data-hovercard-type="pull_request" data-hovercard-url="/open-telemetry/semantic-conventions/pull/2205/hovercard">#2205</a>)</li> <li><code>db</code>: Add an option to generate <code>db.query.summary</code> from operation name and target, remove it from CosmosDB. (<a href="open-telemetry/semantic-conventions#2206" data-hovercard-type="pull_request" data-hovercard-url="/open-telemetry/semantic-conventions/pull/2206/hovercard">#2206</a>)</li> <li><code>db</code>: Add <code>db.operation.name</code> and <code>db.collection.name</code> to SQL for higher-level APIs (<a href="open-telemetry/semantic-conventions#2207" data-hovercard-type="pull_request" data-hovercard-url="/open-telemetry/semantic-conventions/pull/2207/hovercard">#2207</a>)</li> <li><code>jvm</code>: Add <code>jvm.file_descriptor.count</code> as an in-development metric to track the number of open file descriptors as reported by the JVM. (<a href="open-telemetry/semantic-conventions#1838" data-hovercard-type="issue" data-hovercard-url="/open-telemetry/semantic-conventions/issues/1838/hovercard">#1838</a>)</li> <li><code>jvm</code>: Add <code>jvm.gc.cause</code> to metric <code>jvm.gc.duration</code> as an opt-in attribute to track gc cause. (<a href="open-telemetry/semantic-conventions#2065" data-hovercard-type="issue" data-hovercard-url="/open-telemetry/semantic-conventions/issues/2065/hovercard">#2065</a>)</li> <li><code>process</code>: Add process.environment_variable. (<a href="open-telemetry/semantic-conventions#672" data-hovercard-type="issue" data-hovercard-url="/open-telemetry/semantic-conventions/issues/672/hovercard">#672</a>)</li> <li><code>app</code>: Defines two new click events for the app domain (<a href="open-telemetry/semantic-conventions#2070" data-hovercard-type="pull_request" data-hovercard-url="/open-telemetry/semantic-conventions/pull/2070/hovercard">#2070</a>)</li> <li><code>code</code>: Mark <code>code.*</code> semantic conventions as stable (<a href="open-telemetry/semantic-conventions#1377" data-hovercard-type="issue" data-hovercard-url="/open-telemetry/semantic-conventions/issues/1377/hovercard">#1377</a>)</li> <li><code>k8s</code>: Introduce semantic conventions for k8s CronJob labels and annotations (<a href="open-telemetry/semantic-conventions#2138" data-hovercard-type="issue" data-hovercard-url="/open-telemetry/semantic-conventions/issues/2138/hovercard">#2138</a>)</li> <li><code>k8s</code>: Introduce semantic conventions for k8s DaemonSet labels and annotations (<a href="open-telemetry/semantic-conventions#2136" data-hovercard-type="issue" data-hovercard-url="/open-telemetry/semantic-conventions/issues/2136/hovercard">#2136</a>)</li> <li><code>k8s</code>: Introduce semantic conventions for k8s Deployment labels and annotations (<a href="open-telemetry/semantic-conventions#2134" data-hovercard-type="issue" data-hovercard-url="/open-telemetry/semantic-conventions/issues/2134/hovercard">#2134</a>)</li> <li><code>system</code>: Added entity association template rendering and policies. (<a href="open-telemetry/semantic-conventions#1276" data-hovercard-type="issue" data-hovercard-url="/open-telemetry/semantic-conventions/issues/1276/hovercard">#1276</a>)</li> <li><code>gen_ai</code>: Document <code>generate_content</code> as a permissible value of <code>gen_ai.operation.name</code>. (<a href="open-telemetry/semantic-conventions#2048" data-hovercard-type="issue" data-hovercard-url="/open-telemetry/semantic-conventions/issues/2048/hovercard">#2048</a>)</li> <li><code>k8s</code>: Introduce semantic conventions for k8s Job labels and annotations (<a href="open-telemetry/semantic-conventions#2137" data-hovercard-type="issue" data-hovercard-url="/open-telemetry/semantic-conventions/issues/2137/hovercard">#2137</a>)</li> <li><code>otel</code>: Adds SDK self-monitoring metrics for metric processing (<a href="open-telemetry/semantic-conventions#2016" data-hovercard-type="pull_request" data-hovercard-url="/open-telemetry/semantic-conventions/pull/2016/hovercard">#2016</a>)</li> <li><code>k8s</code>: Introduce semantic conventions for k8s Namespace labels and annotations (<a href="open-telemetry/semantic-conventions#2131" data-hovercard-type="issue" data-hovercard-url="/open-telemetry/semantic-conventions/issues/2131/hovercard">#2131</a>)</li> <li><code>k8s</code>: Introduce semantic conventions for k8s Node labels and annotations (<a href="open-telemetry/semantic-conventions#2079" data-hovercard-type="issue" data-hovercard-url="/open-telemetry/semantic-conventions/issues/2079/hovercard">#2079</a>)</li> <li><code>k8s</code>: Introduce semantic conventions for k8s ReplicaSet labels and annotations (<a href="open-telemetry/semantic-conventions#2132" data-hovercard-type="issue" data-hovercard-url="/open-telemetry/semantic-conventions/issues/2132/hovercard">#2132</a>)</li> <li><code>otel</code>: Adds SDK self-monitoring metric for exporter call duration (<a href="open-telemetry/semantic-conventions#1906" data-hovercard-type="issue" data-hovercard-url="/open-telemetry/semantic-conventions/issues/1906/hovercard">#1906</a>)</li> <li><code>k8s</code>: Introduce semantic conventions for k8s StatefulSet labels and annotations (<a href="open-telemetry/semantic-conventions#2135" data-hovercard-type="issue" data-hovercard-url="/open-telemetry/semantic-conventions/issues/2135/hovercard">#2135</a>)</li> </ul> <h3>🧰 Bug fixes 🧰</h3> <ul> <li><code>gen-ai</code>: Removed irrelevant response attributes on GenAI create agent span. (<a href="open-telemetry/semantic-conventions#1924" data-hovercard-type="issue" data-hovercard-url="/open-telemetry/semantic-conventions/issues/1924/hovercard">#1924</a>, <a href="open-telemetry/semantic-conventions#2116" data-hovercard-type="pull_request" data-hovercard-url="/open-telemetry/semantic-conventions/pull/2116/hovercard">#2116</a>)</li> <li><code>vcs</code>: Fix typo in gitea name (<a href="open-telemetry/semantic-conventions#2057" data-hovercard-type="issue" data-hovercard-url="/open-telemetry/semantic-conventions/issues/2057/hovercard">#2057</a>)</li> <li><code>gen-ai</code>: Add invoke_agent as a member of gen_ai.operation.name (<a href="open-telemetry/semantic-conventions#2160" data-hovercard-type="pull_request" data-hovercard-url="/open-telemetry/semantic-conventions/pull/2160/hovercard">#2160</a>)</li> <li><code>db</code>: Clarify <code>db.query.summary</code> for stored procedures (<a href="open-telemetry/semantic-conventions#2218" data-hovercard-type="pull_request" data-hovercard-url="/open-telemetry/semantic-conventions/pull/2218/hovercard">#2218</a>)</li> </ul>

introduce app click event semconv

6ca6d44

breedx-splk requested review from a team as code owners April 8, 2025 22:25

github-project-automation bot added this to Semantic Conventions Triage Apr 8, 2025

github-project-automation bot moved this to Untriaged in Semantic Conventions Triage Apr 8, 2025

add changelog item.

3642a14

github-actions bot added the enhancement New feature or request label Apr 8, 2025

breedx-splk and others added 2 commits April 8, 2025 15:30

fix event ids

2f30db9

Merge branch 'main' into app_click_events

a642572

cleverchuk approved these changes Apr 8, 2025

View reviewed changes

LikeTheSalad approved these changes Apr 9, 2025

View reviewed changes

bidetofevil reviewed Apr 9, 2025

View reviewed changes

docs/app/app.md Outdated Show resolved Hide resolved

docs/app/app.md Outdated Show resolved Hide resolved

docs/app/app.md Outdated Show resolved Hide resolved

docs/app/app.md Show resolved Hide resolved

docs/app/app.md Outdated Show resolved Hide resolved

trask reviewed Apr 9, 2025

View reviewed changes

model/app/registry.yaml Show resolved Hide resolved

breedx-splk added 3 commits April 9, 2025 09:07

Merge branch 'main' into app_click_events

6cb053d

Merge branch 'main' into app_click_events

56b3a03

Merge branch 'main' into app_click_events

dee3797

trask mentioned this pull request Apr 9, 2025

Add Browser UserAction Event #1941

Closed

3 tasks

trask previously requested changes Apr 9, 2025

View reviewed changes

github-project-automation bot moved this from Untriaged to Blocked in Semantic Conventions Triage Apr 9, 2025

bidetofevil approved these changes Apr 9, 2025

View reviewed changes

Merge branch 'main' into app_click_events

3046da9

jzwc reviewed Apr 17, 2025

View reviewed changes

docs/app/app.md Show resolved Hide resolved

trask mentioned this pull request Apr 17, 2025

Provide guidance on modeling lat/lon, x/y, etc #2145

Merged

Merge branch 'main' into app_click_events

06aafab

breedx-splk requested a review from a team as a code owner April 18, 2025 15:26

fix copypasta bug

bd3d898

breedx-splk added 2 commits April 18, 2025 11:24

move attributes down

55a1e19

lint

9cccf9b

trask approved these changes Apr 18, 2025

View reviewed changes

github-project-automation bot moved this from Blocked to Needs More Approval in Semantic Conventions Triage Apr 18, 2025

lmolkova reviewed Apr 18, 2025

View reviewed changes

docs/app/app.md Outdated Show resolved Hide resolved

lmolkova approved these changes Apr 18, 2025

View reviewed changes

breedx-splk and others added 2 commits April 18, 2025 15:08

Update docs/app/app.md

d366beb

Co-authored-by: Liudmila Molkova <[email protected]>

make markdown-toc

b06c4ba

lmolkova moved this from Needs More Approval to Ready to be Merged in Semantic Conventions Triage Apr 19, 2025

jzwc reviewed Apr 19, 2025

View reviewed changes

docs/app/app.md Show resolved Hide resolved

breedx-splk mentioned this pull request Apr 21, 2025

Add jank events for slow app rendering #2157

Closed

trask reviewed Apr 22, 2025

View reviewed changes

model/app/registry.yaml Show resolved Hide resolved

based on client sig discussions and agreed upon guidance, change the …

8ad7997

…coordinate to be a 2 element array with xy in the key name.

lmolkova reviewed Apr 22, 2025

View reviewed changes

model/app/registry.yaml Outdated Show resolved Hide resolved

lmolkova moved this from Ready to be Merged to Blocked in Semantic Conventions Triage Apr 27, 2025

jsuereth requested changes Apr 28, 2025

View reviewed changes

model/app/registry.yaml Outdated Show resolved Hide resolved

lmolkova self-requested a review April 28, 2025 20:36

Revert "based on client sig discussions and agreed upon guidance, cha…

1ada30c

…nge the coordinate to be a 2 element array with xy in the key name." This reverts commit 8ad7997.

lmolkova approved these changes Apr 29, 2025

View reviewed changes

jsuereth approved these changes May 1, 2025

View reviewed changes

github-project-automation bot moved this from Blocked to Needs More Approval in Semantic Conventions Triage May 1, 2025

trask added this pull request to the merge queue May 1, 2025

Merged via the queue into open-telemetry:main with commit 48c9127 May 1, 2025
15 checks passed

lmolkova pushed a commit to lmolkova/semantic-conventions that referenced this pull request May 13, 2025

Introduce app click events (open-telemetry#2070)

3c5ecec

Co-authored-by: Liudmila Molkova <[email protected]>

MrAlias mentioned this pull request May 20, 2025

Generate semconv/v1.33.0 open-telemetry/opentelemetry-go#6799

Merged

Introduce app click events #2070

Introduce app click events #2070

Uh oh!

Conversation

breedx-splk commented Apr 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Merge requirement checklist

Uh oh!

cleverchuk left a comment

Choose a reason for hiding this comment

Uh oh!

LikeTheSalad left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

breedx-splk commented Apr 9, 2025

Uh oh!

trask left a comment

Choose a reason for hiding this comment

Uh oh!

bidetofevil left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

trask commented Apr 18, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jsuereth commented Apr 28, 2025

Uh oh!

breedx-splk commented Apr 28, 2025

Uh oh!

breedx-splk commented Apr 29, 2025

Uh oh!

jsuereth left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

breedx-splk commented Apr 8, 2025 •

edited

Loading